git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Kirill Smelkov <kirr@mns.spb.ru>,
	git@vger.kernel.org
Subject: Re: [REGRESSION, BISECTED] `git checkout <branch>` started to be memory hog
Date: Fri, 22 Jul 2011 13:26:17 -0700	[thread overview]
Message-ID: <7vaac6ysd2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110722173601.GA9422@sigill.intra.peff.net> (Jeff King's message of "Fri, 22 Jul 2011 11:36:02 -0600")

Jeff King <peff@peff.net> writes:

> Did you want me to write a commit message? I think you might do a better
> job of writing a coherent one for this particular patch.

I didn't do a very good job.

commit 06a21454b424d5bc0a36ed76ce46bb16ed156774
Author: Jeff King <peff@peff.net>
Date:   Fri Jul 22 11:00:03 2011 -0600

    streaming: free git_istream upon closing
    
    Kirill Smelkov noticed that post 1.7.6 "git checkout" started leaking
    tons of memory. close_istream() forgot to release its buffer and the
    caller was not freeing it, either.
    
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

At least it needs your S-o-b ;-).

  reply	other threads:[~2011-07-22 20:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 13:05 [REGRESSION, BISECTED] `git checkout <branch>` started to be memory hog Kirill Smelkov
2011-07-22 17:00 ` Jeff King
2011-07-22 17:33   ` Junio C Hamano
2011-07-22 17:36     ` Jeff King
2011-07-22 20:26       ` Junio C Hamano [this message]
2011-07-22 20:36         ` Jeff King
2011-07-22 21:31           ` Junio C Hamano
2011-07-23 18:04             ` Kirill Smelkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vaac6ysd2.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kirr@mns.spb.ru \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).