From: Junio C Hamano <gitster@pobox.com>
To: Jonathon Mah <me@JonathonMah.com>
Cc: git@vger.kernel.org, Charles Bailey <charles@hashpling.org>
Subject: Re: [PATCH 1/2] mergetool: Add tests for filename with whitespace
Date: Wed, 22 Jun 2011 14:11:14 -0700 [thread overview]
Message-ID: <7vaad9607h.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <734F376D-0CF5-4417-8DC2-8A46AA05D995@JonathonMah.com> (Jonathon Mah's message of "Tue, 21 Jun 2011 19:40:23 -0700")
Jonathon Mah <me@JonathonMah.com> writes:
> Signed-off-by: Jonathon Mah <me@JonathonMah.com>
> ---
Missing log message. What is the purpose of these new tests?
You found a bug in the current implementation of mergetool (and then fixed
with your next patch)? Your earlier unpublished attempts for your next
patch did not work for paths with IFS in it, and you wanted to make sure
that future changes to your next patch will not be broken?
prev parent reply other threads:[~2011-06-22 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 2:40 [PATCH 1/2] mergetool: Add tests for filename with whitespace Jonathon Mah
2011-06-22 21:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaad9607h.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=me@JonathonMah.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).