From: Junio C Hamano <gitster@pobox.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 2/3] git-log.txt,rev-list-options.txt: -n/--max-count is commit limiting
Date: Tue, 08 Mar 2011 11:59:22 -0800 [thread overview]
Message-ID: <7vaah5e63p.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4c0ad5a9af1d18e59a7e820349a531f220cbf776.1299572814.git.git@drmicha.warpmail.net> (Michael J. Gruber's message of "Tue, 8 Mar 2011 09:31:25 +0100")
Michael J Gruber <git@drmicha.warpmail.net> writes:
> diff --git a/Documentation/git-log.txt b/Documentation/git-log.txt
> index ff41784..48c1715 100644
> --- a/Documentation/git-log.txt
> +++ b/Documentation/git-log.txt
> @@ -25,6 +25,7 @@ OPTIONS
>
> -<n>::
> Limits the number of commits to show.
> + Note that this is a commit limiting option, see below.
I wonder if we should be dropping this instead, as it appears later in the
document anyway.
> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
> index 76add13..adcafa0 100644
> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -158,7 +158,8 @@ Commit Limiting
>
> Besides specifying a range of commits that should be listed using the
> special notations explained in the description, additional commit
> -limiting may be applied.
> +limiting may be applied. Note that they are applied before commit
> +ordering and formatting options, such as '--reverse'.
This part is probably a good addition.
next prev parent reply other threads:[~2011-03-08 19:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 19:17 --max-count useless with git-rev-list's --reverse Ævar Arnfjörð Bjarmason
2011-03-07 19:40 ` Shawn Pearce
2011-03-08 7:35 ` Jay Soffian
2011-03-08 8:34 ` Michael J Gruber
2011-03-08 8:30 ` Michael J Gruber
2011-03-08 8:31 ` [PATCH 1/3] rev-list-options.txt: typo fix Michael J Gruber
2011-03-08 8:31 ` [PATCH 2/3] git-log.txt,rev-list-options.txt: -n/--max-count is commit limiting Michael J Gruber
2011-03-08 19:59 ` Junio C Hamano [this message]
2011-03-09 7:11 ` Michael J Gruber
2011-03-08 8:31 ` [PATCH 3/3] git-log.txt,rev-list-options.txt: put option blocks in proper order Michael J Gruber
2011-03-09 23:38 ` Junio C Hamano
2011-03-10 7:50 ` Michael J Gruber
2011-03-08 19:56 ` [PATCH 1/3] rev-list-options.txt: typo fix Junio C Hamano
2011-03-09 7:07 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaah5e63p.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).