* [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration
@ 2011-01-01 20:31 Ramsay Jones
2011-01-11 18:33 ` Ramsay Jones
0 siblings, 1 reply; 3+ messages in thread
From: Ramsay Jones @ 2011-01-01 20:31 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list, kusmabite
Commit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed
the compat/vcbuild/include/dirent.h compatibility header file.
This file, among other things, included the <io.h> system header
file which provides the declaration of the mktemp() function.
In order to fix the compilation error, we add an include directive
for <io.h> to the compat/mingw.h header.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Change from v1:
- add #include to compat/mingw.h rather than compat/vcbuild/include/unistd.h
ATB,
Ramsay Jones
compat/mingw.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/compat/mingw.h b/compat/mingw.h
index cafc1eb..1c6bc02 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -1,5 +1,6 @@
#include <winsock2.h>
#include <ws2tcpip.h>
+#include <io.h>
/*
* things that are not available in header files
--
1.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration
2011-01-01 20:31 [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration Ramsay Jones
@ 2011-01-11 18:33 ` Ramsay Jones
2011-01-11 20:14 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Ramsay Jones @ 2011-01-11 18:33 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list, kusmabite
Ramsay Jones wrote:
> Commit d1b6e6e (win32: use our own dirent.h, 2010-11-23) removed
> the compat/vcbuild/include/dirent.h compatibility header file.
> This file, among other things, included the <io.h> system header
> file which provides the declaration of the mktemp() function.
>
> In order to fix the compilation error, we add an include directive
> for <io.h> to the compat/mingw.h header.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Change from v1:
> - add #include to compat/mingw.h rather than compat/vcbuild/include/unistd.h
>
> ATB,
> Ramsay Jones
>
> compat/mingw.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/compat/mingw.h b/compat/mingw.h
> index cafc1eb..1c6bc02 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -1,5 +1,6 @@
> #include <winsock2.h>
> #include <ws2tcpip.h>
> +#include <io.h>
>
> /*
> * things that are not available in header files
ping... Are there any remaining concerns regarding this patch?
Just let me know.
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration
2011-01-11 18:33 ` Ramsay Jones
@ 2011-01-11 20:14 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2011-01-11 20:14 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list, kusmabite
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> ping... Are there any remaining concerns regarding this patch?
I dunno. Is everybody on the Windows side happy with it?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-11 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-01 20:31 [PATCH v2] msvc: Fix compilation error due to missing mktemp() declaration Ramsay Jones
2011-01-11 18:33 ` Ramsay Jones
2011-01-11 20:14 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).