From: Junio C Hamano <gitster@pobox.com>
To: Jared Hance <jaredhance@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC] struct *_struct
Date: Wed, 04 Aug 2010 12:24:29 -0700 [thread overview]
Message-ID: <7vaap2fafm.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100804150843.GA2762@localhost.localdomain> (Jared Hance's message of "Wed\, 4 Aug 2010 11\:08\:43 -0400")
Jared Hance <jaredhance@gmail.com> writes:
> - We use this style in only 3 cases
I think they were early-days inertia between me and Linus. I hate "struct
foo_struct" (and "typedef foo struct foo") myself and that is why we don't
see many others.
I am personally Ok if you want to give them more sensible names. Doing
s/_struct$// is a no-brainer for "diff_queue_struct", but I do not think
doing that alone would be a good idea for "cmd_struct" and "dir_struct".
I'd suggest calling the former "cmd_desc", as it is a set of info on a
single command. "dir_struct" is a table that records a set of paths in
the whole work tree and it is not about a single directory (nor a single
entry in that table, which is "dir_entry"); as such "dir" that sounds too
similar to DIR that is what opendir() returns (i.e. a single directory)
may probably not be a good name for it.
next prev parent reply other threads:[~2010-08-04 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 15:08 [RFC] struct *_struct Jared Hance
2010-08-04 19:24 ` Junio C Hamano [this message]
2010-08-04 21:38 ` [PATCH] Refactor structures in the form of *_struct Jared Hance
2010-08-05 16:20 ` [RFC] struct *_struct Michael Witten
2010-08-05 22:43 ` Jared Hance
2010-08-06 3:57 ` Michael Witten
2010-08-06 12:29 ` Jared Hance
2010-08-06 2:28 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaap2fafm.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaredhance@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).