From: Junio C Hamano <gitster@pobox.com>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] INSTALL: Update description of our SHA-1 code
Date: Tue, 08 Sep 2009 13:21:01 -0700 [thread overview]
Message-ID: <7vab15yyqa.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1252425313-69793-1-git-send-email-brian@gernhardtsoftware.com
Brian Gernhardt <brian@gernhardtsoftware.com> writes:
> We haven't had Mozilla's code or an ARM optimized algorithm since
> 30ae47b. Reword the paragraph to give credit but not authorship to
> Mozilla.
Thanks.
> Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
> ---
>
> Minor nit I noticed while in the INSTALL file.
>
> INSTALL | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index ae7f750..4a57e47 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -56,8 +56,8 @@ Issues of note:
> library from here.
>
> If you don't have openssl, you can use one of the SHA1 libraries
> - that come with git (git includes the one from Mozilla, and has
> - its own PowerPC and ARM optimized ones too - see the Makefile).
> + that come with git (git includes one based on Mozilla's as well
> + as a PowerPC optimized one - see the Makefile).
The leading comment in block/sha1.c says "initially based on ... although
none of the original remains." "one loosely based on" or "one inspired
by" might be a more fair statement, although I do not feel too strongly
about it.
>
> - libcurl library; git-http-fetch and git-fetch use them. You
> might also want the "curl" executable for debugging purposes.
> --
> 1.6.4.2.420.g30ecf
prev parent reply other threads:[~2009-09-08 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 15:55 [PATCH 1/2] INSTALL: Update description of our SHA-1 code Brian Gernhardt
2009-09-08 15:55 ` [RFC PATCH 2/2] INSTALL: Describe a few knobs from the Makefile Brian Gernhardt
2009-09-08 20:26 ` Junio C Hamano
2009-09-09 0:12 ` Brian Gernhardt
2009-09-08 20:21 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vab15yyqa.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).