From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: jidanni@jidanni.org, git@vger.kernel.org
Subject: Re: [PATCH] Documentation/gitcli.txt: dashed forms not allowed anymore
Date: Thu, 01 Jan 2009 13:00:39 -0800 [thread overview]
Message-ID: <7vabaaivwo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090101144045.GC21154@genesis.frugalware.org
Miklos Vajna <vmiklos@frugalware.org> writes:
> On Thu, Jan 01, 2009 at 12:39:39PM +0800, jidanni@jidanni.org wrote:
>> - * it's preferred to use the non dashed form of git commands, which means that
>> - you should prefer `"git foo"` to `"git-foo"`.
>> + * it's required to use the non dashed form of git commands, which means that
>> + you must use `"git foo"` and not `"git-foo"`. The latter no longer works.
>
> I would append: "unless you add the output of `git --exec-path` to your
> PATH."
I actually wouldn't.
There needs to be a description about use of PATH=$(git --exec-path):$PATH
if you choose to use the dashed forms in your script. Don't we already
have that elsewhere more basic in the documentation set?
The quoted part of the documentation talks about the syntax and convention
used while scripting, and what it wants to say with the sentence is that
the dashless form is preferred, even with PATH=$(git --exec-path):$PATH
(iow, it was preferred before 1.6.0, and it still is preferred with the
$PATH adjustments after 1.6.0).
I think it muddies the point of the list if you talk about the necessity
of $PATH adjustment, which is a irrelevant detail.
prev parent reply other threads:[~2009-01-01 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 4:39 [PATCH] Documentation/gitcli.txt: dashed forms not allowed anymore jidanni
2009-01-01 14:40 ` Miklos Vajna
2009-01-01 21:00 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabaaivwo.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jidanni@jidanni.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).