From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Nicolas Pitre <nico@cam.org>, Alex Riesen <raa.lkml@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] make sure packs to be replaced are closed beforehand
Date: Wed, 10 Dec 2008 00:27:14 -0800 [thread overview]
Message-ID: <7vabb43065.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <493F71B7.60804@viscovery.net> (Johannes Sixt's message of "Wed, 10 Dec 2008 08:37:27 +0100")
Johannes Sixt <j.sixt@viscovery.net> writes:
> Nicolas Pitre schrieb:
>> Especially on Windows where an opened file cannot be replaced, make
>> sure pack-objects always close packs it is about to replace. Even on
>> non Windows systems, this could save potential bad results if ever
>> objects were to be read from the new pack file using offset from the old
>> index.
>>
>> This should fix t5303 on Windows.
> ...
>> OK, here it is at last. Please confirm it works on Windows before Junio
>> merges it.
>
> I can confirm that this patch fixes t5303 on Windows (MinGW).
Thanks; it is a bit too late for tonight, but it will appear in tomorrow's
'master'.
next prev parent reply other threads:[~2008-12-10 8:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 11:13 [PATCH] Fix handle leak in builtin-pack-objects Alex Riesen
2008-11-19 11:54 ` Johannes Sixt
2008-11-19 12:13 ` Alex Riesen
2008-11-19 12:26 ` Johannes Sixt
2008-11-19 12:55 ` Nicolas Pitre
2008-11-19 13:06 ` Johannes Sixt
2008-11-19 14:31 ` Nicolas Pitre
2008-11-19 13:34 ` Alex Riesen
2008-11-19 13:55 ` Johannes Sixt
2008-11-19 14:17 ` Alex Riesen
2008-11-19 14:42 ` Nicolas Pitre
2008-11-19 14:52 ` Johannes Sixt
2008-11-19 16:25 ` [PATCH] compat/mingw.c: Teach mingw_rename() to replace read-only files Johannes Sixt
2008-11-26 13:18 ` [PATCH] Fix handle leak in builtin-pack-objects Alex Riesen
2008-11-26 14:33 ` Nicolas Pitre
2008-11-26 18:43 ` Alex Riesen
2008-12-09 19:26 ` [PATCH] make sure packs to be replaced are closed beforehand Nicolas Pitre
2008-12-09 19:33 ` Alex Riesen
2008-12-10 7:37 ` Johannes Sixt
2008-12-10 8:27 ` Junio C Hamano [this message]
2008-12-10 9:36 ` Alex Riesen
2008-11-19 12:45 ` [PATCH] Fix handle leak in builtin-pack-objects Nicolas Pitre
2008-11-19 13:30 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabb43065.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=nico@cam.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).