From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Pierre Habouzit <madcoder@debian.org>, git@vger.kernel.org
Subject: Re: [PATCH] parse-opt: migrate builtin-checkout-index.
Date: Sun, 19 Oct 2008 13:11:31 -0700 [thread overview]
Message-ID: <7vabd073bg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1224441040-5071-1-git-send-email-vmiklos@frugalware.org> (Miklos Vajna's message of "Sun, 19 Oct 2008 20:30:40 +0200")
Miklos Vajna <vmiklos@frugalware.org> writes:
> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
>
> On Sat, Oct 18, 2008 at 03:17:23AM +0200, Miklos Vajna <vmiklos@frugalware.org> wrote:
>> > This adds a new feature to say --no-z from the command line, doesn't
>> > it?
>> > And I suspect the feature is broken ;-).
>>
>> Right, I fixed this in option_parse_z(). --no-z should set
>> line_termination to \n instead of 1.
>
> Originally in option_parse_z() I had
>
> line_termination = unset;
>
> which is in fact right, because (as Pierre pointed out) unset for short
> options are always false, but I changed it to
>
> line_termination = 0;
>
> to make it more readable.
I think Pierre's comment is short-sighted. Think of what would happen
when somebody adds "--nul" as a longer equivalent to "-z", since it is
extremely easy to do things like that with the use of parse-opt API?
next prev parent reply other threads:[~2008-10-19 20:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 22:55 [PATCH] parse-opt: migrate builtin-checkout-index Miklos Vajna
2008-10-16 8:23 ` Pierre Habouzit
2008-10-16 13:28 ` [PATCH v2] " Miklos Vajna
2008-10-17 23:58 ` Junio C Hamano
2008-10-18 1:17 ` [PATCH] " Miklos Vajna
2008-10-19 18:30 ` Miklos Vajna
2008-10-19 18:31 ` Miklos Vajna
2008-10-19 20:11 ` Junio C Hamano [this message]
2008-10-19 20:19 ` Pierre Habouzit
2008-10-19 20:59 ` Junio C Hamano
2008-10-19 19:29 ` Raphael Zimmerer
2008-10-19 19:34 ` Pierre Habouzit
2008-10-19 21:45 ` Junio C Hamano
2008-10-18 15:54 ` [PATCH v2] " Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabd073bg.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).