From: Junio C Hamano <gitster@pobox.com>
To: Marcus Griep <marcus@griep.us>
Cc: Petr Baudis <pasky@suse.cz>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] count-objects: add human-readable size option
Date: Thu, 14 Aug 2008 17:10:25 -0700 [thread overview]
Message-ID: <7vabffcf4e.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <48A4C521.6090507@griep.us> (Marcus Griep's message of "Thu, 14 Aug 2008 19:52:01 -0400")
Marcus Griep <marcus@griep.us> writes:
> Petr Baudis wrote:
>>> +-H::
>>
>> Can you guess what would I bug you about? ;-)
>
> If we get '-h', I'll submit another patch :-P
Wasn't the problem about documenting the addition of pack size, which is
not about this human-readable option?
>> If it's non-human-readable anyway, why are you dividing this by 1024? At
>> any rate, it is not obvious at all that the size-pack is not actually
>> size-pack but size-pack/1024. You should either add the (fixed) unit
>> string behind or name it size-pack-kb - or just not divide it at all?
>
> I divide by 1024 here because the loose object size is reported in KiB.
> The total that ends up in size_pack is in B, hence to be consistent, I
> report the pack size in KiB as well.
I thought this part was ok without room for dispute.
next prev parent reply other threads:[~2008-08-15 0:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 22:18 [PATCH v2 0/3] count-objects size and strbuf human-readable Marcus Griep
2008-08-14 22:18 ` [PATCH v2 1/3] count-objects: Add total pack size to verbose output Marcus Griep
2008-08-14 22:18 ` [PATCH v2 2/3] strbuf: Add method to convert byte-size to human readable form Marcus Griep
2008-08-14 22:18 ` [PATCH v2 3/3] count-objects: add human-readable size option Marcus Griep
2008-08-14 22:37 ` Petr Baudis
2008-08-14 23:52 ` Marcus Griep
2008-08-15 0:10 ` Junio C Hamano [this message]
2008-08-14 22:34 ` [PATCH v2 2/3] strbuf: Add method to convert byte-size to human readable form Petr Baudis
2008-08-14 23:04 ` Junio C Hamano
2008-08-14 23:24 ` Petr Baudis
2008-08-14 23:40 ` Junio C Hamano
2008-08-15 0:53 ` Marcus Griep
2008-08-15 0:46 ` Marcus Griep
2008-08-15 0:52 ` Shawn O. Pearce
2008-08-15 4:20 ` [PATCH v3 1/3] count-objects: Add total pack size to verbose output Marcus Griep
2008-08-15 4:20 ` [PATCH v3 2/3] strbuf: Add method to convert byte-size to human readable form Marcus Griep
2008-08-15 4:20 ` [PATCH v3 3/3] count-objects: add human-readable size option Marcus Griep
2008-08-15 15:47 ` [PATCH v3.1 1/3] count-objects: Add total pack size to verbose output Marcus Griep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabffcf4e.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=marcus@griep.us \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).