git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC PATCH] Documentation: rev-list-options: clarify history simplification with paths
Date: Sun, 10 Aug 2008 12:19:13 -0700	[thread overview]
Message-ID: <7vabfk3cge.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1218375840-4292-1-git-send-email-trast@student.ethz.ch> (Thomas Rast's message of "Sun, 10 Aug 2008 15:44:00 +0200")

Thomas Rast <trast@student.ethz.ch> writes:

>   $ g rev-list --pretty=oneline --full-history HEAD -- dir
> ...
> But --parents --full-history magically revives the merge:
> ...

Personally I do not think --full-history without --parents is of much
usefulness (I'd let Linus or somebody else defend this usage, or make it
imply revs.rewrite_parents otherwise).  If you remove that case from your
set of experiments in the equation, do the rest of the results make sense?

> More to the point, --simplify-merges actually shows the merge when
> --full-history does not, resulting in ...

One thing I forgot to mention (but the code of course does not forget to
do) in the series is that --simplify-merges implies revs.rewrite_parents
which roughly translates to your experiments from the command line to
always have --parents option.

>   $ git rev-list --pretty=oneline --sparse --parents --simplify-merges HEAD -- dir
>   e0083e6... aad9982... 984aa48... b3127f4... Merge branches 'side' and 'unrelated'
>   b3127f4... b60c459... d: unrelated
>   984aa48... b60c459... C: dir=B
>   aad9982... b60c459... B: dir
>   b60c459... ad7052b... A: dir
>   ad7052b... initial

I am not sure what one should expect from combination between these two
options.  --sparse says do not drop commits that are of no interest with
respect to the paths specified, while --simplify-merges tells it to
simplify merges so that the remaining graph shows only the ones that have
relevance to !TREESAME (iow "has some changes") nodes.

  reply	other threads:[~2008-08-10 19:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-10 13:44 [RFC PATCH] Documentation: rev-list-options: clarify history simplification with paths Thomas Rast
2008-08-10 19:19 ` Junio C Hamano [this message]
2008-08-10 19:27   ` Linus Torvalds
2008-08-10 21:58     ` Junio C Hamano
2008-08-10 22:16       ` Linus Torvalds
2008-08-10 21:31   ` Thomas Rast
2008-08-11 20:39     ` Junio C Hamano
2008-08-11 20:34 ` Junio C Hamano
2008-08-11 23:51   ` Thomas Rast
2008-08-11 23:55     ` [PATCH 1/3] Documentation: rev-list-options: Fix a typo Thomas Rast
2008-08-11 23:55     ` [PATCH 2/3] Documentation: rev-list-options: Rewrite simplification descriptions for clarity Thomas Rast
2008-08-11 23:55     ` [PATCH 3/3] Documentation: rev-list-options: move --simplify-merges documentation Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabfk3cge.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).