From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH v3-wip] revision traversal: show full history with merge simplification Date: Thu, 31 Jul 2008 20:00:58 -0700 Message-ID: <7vabfxv3px.fsf@gitster.siamese.dyndns.org> References: <8502DF7C-5303-49E8-8C67-F837343E2F0C@gmail.com> <46a038f90807282015m7ce3da10h71dfee221c960332@mail.gmail.com> <7vej5b3ozz.fsf@gitster.siamese.dyndns.org> <7vhca6zcuy.fsf@gitster.siamese.dyndns.org> <7vabfxyacx.fsf_-_@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Roman Zippel , Martin Langhoff , Tim Harper , git@vger.kernel.org To: Linus Torvalds X-From: git-owner@vger.kernel.org Fri Aug 01 05:03:25 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOkuE-0002jD-7J for gcvg-git-2@gmane.org; Fri, 01 Aug 2008 05:02:14 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbYHADBN (ORCPT ); Thu, 31 Jul 2008 23:01:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753572AbYHADBM (ORCPT ); Thu, 31 Jul 2008 23:01:12 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:49537 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753094AbYHADBL (ORCPT ); Thu, 31 Jul 2008 23:01:11 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id E85A848BE6; Thu, 31 Jul 2008 23:01:09 -0400 (EDT) Received: from pobox.com (ip68-225-240-211.oc.oc.cox.net [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 3DCA248BE5; Thu, 31 Jul 2008 23:01:04 -0400 (EDT) In-Reply-To: (Linus Torvalds's message of "Thu, 31 Jul 2008 15:26:17 -0700 (PDT)") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 17B35094-5F76-11DD-B2CE-CE28B26B55AE-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Linus Torvalds writes: > On Thu, 31 Jul 2008, Junio C Hamano wrote: >> >> The same query with 's/| head -n 1/>/dev/null' is more expensive. In fact >> it is much more expensive than the non-incremental one (v2), and about >> three times more expensive than non-limiting --full-history for explaining >> the history of kernel/printk.c. > > Hmm? Why is that, exactly? Does it walk over the same commit over and over > and over again or something? It was even worse than that. The output from v3 is incorrect, as the place the new call is hooked into knows only that the commit in question is not UNINTERESTING, but hasn't inspected its parents, but the simplification logic needs to dig into the parent chain deep enough, which it does not do correctly using the proper simplification logic (i.e. add_parents_to_list()).