From: Junio C Hamano <gitster@pobox.com>
To: "Fernando J. Pereda" <ferdy@ferdyx.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Skip unwritable tests for root
Date: Mon, 30 Jun 2008 02:08:18 -0700 [thread overview]
Message-ID: <7vabh31e9p.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1214809551-14603-1-git-send-email-ferdy@ferdyx.org
"Fernando J. Pereda" <ferdy@ferdyx.org> writes:
> Signed-off-by: Fernando J. Pereda <ferdy@ferdyx.org>
Hmm. Actually we've deliberately ignored this so far. If we were to do
anything, don't we rather want to fail everything upfront when the tests
are run by root?
Running "make" and "make test" before "make install" is so that you have
less chance hurting your running system, and I find it simply crazy to
build (i.e. "make all") as root, let alone running tests.
next prev parent reply other threads:[~2008-06-30 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 7:05 [PATCH] Skip unwritable tests for root Fernando J. Pereda
2008-06-30 7:39 ` Jakub Narebski
2008-06-30 9:08 ` Junio C Hamano [this message]
2008-06-30 9:27 ` Fernando J. Pereda
2008-07-07 19:14 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabh31e9p.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=ferdy@ferdyx.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).