Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Twiinz]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

In git-gui after clicking either on 'Create New Repository' or 'Open
Existing Repository' the form elements aren't centered like they are
pretty much everywhere else in the app. At least when ran on a mac,
haven't checked on other platforms.

Using grid instead of pack seems to fix this.

Hope that helps, cheers,
/twiinz

[-- Attachment #2: choose_repository.tcl.patch --]
[-- Type: application/octet-stream, Size: 857 bytes --]

--- choose_repository.old.tcl	2008-05-18 11:54:23.000000000 +0700
+++ choose_repository.tcl	2008-05-18 11:56:41.000000000 +0700
@@ -388,9 +388,7 @@ method _do_new {} {
 		-command [cb _new_local_path]
 	set w_localpath $w_body.where.t
 
-	pack $w_body.where.b -side right
-	pack $w_body.where.l -side left
-	pack $w_body.where.t -fill x
+	grid $w_body.where.l $w_body.where.t $w_body.where.b -sticky ew
 	pack $w_body.where -fill x
 
 	trace add variable @local_path write [cb _write_local_path]
@@ -987,9 +985,7 @@ method _do_open {} {
 		-text [mc "Browse"] \
 		-command [cb _open_local_path]
 
-	pack $w_body.where.b -side right
-	pack $w_body.where.l -side left
-	pack $w_body.where.t -fill x
+	grid $w_body.where.l $w_body.where.t $w_body.where.b -sticky ew
 	pack $w_body.where -fill x
 
 	trace add variable @local_path write [cb _write_local_path]

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Shawn O. Pearce]

Twiinz <twiinz@gmail.com> wrote:
> In git-gui after clicking either on 'Create New Repository' or 'Open
> Existing Repository' the form elements aren't centered like they are
> pretty much everywhere else in the app. At least when ran on a mac,
> haven't checked on other platforms.
> 
> Using grid instead of pack seems to fix this.

Thanks.  This is a reasonable solution.  Signed-off-by tag?  Do you
want the attribution to be just "Twiinz <twiinz@gmail.com>"?

I ask because the patch is a valid patch and it does apply, but it
isn't a standard git patch and wasn't sent inline, so git-am wasn't
able to extract and apply everything for me automagically.

-- 
Shawn.

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Twiinz]

Hi Shawn,

No worries for Signed-off-by and "Twiinz <twiinz@gmail.com>" for the
attribution.

Sorry for the lack of information in the patch, I'm rather new to
that, I'll check out how to make it better for future contributions.

Cheers,
/twiinz

On Mon, May 19, 2008 at 11:07 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Twiinz <twiinz@gmail.com> wrote:
>> In git-gui after clicking either on 'Create New Repository' or 'Open
>> Existing Repository' the form elements aren't centered like they are
>> pretty much everywhere else in the app. At least when ran on a mac,
>> haven't checked on other platforms.
>>
>> Using grid instead of pack seems to fix this.
>
> Thanks.  This is a reasonable solution.  Signed-off-by tag?  Do you
> want the attribution to be just "Twiinz <twiinz@gmail.com>"?
>
> I ask because the patch is a valid patch and it does apply, but it
> isn't a standard git patch and wasn't sent inline, so git-am wasn't
> able to extract and apply everything for me automagically.
>
> --
> Shawn.
>

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Johannes Schindelin]

Hi,

On Mon, 19 May 2008, Twiinz wrote:

> No worries for Signed-off-by and "Twiinz <twiinz@gmail.com>" for the
> attribution.

Umm.

The Signed-off-by is not so much for _you_ as for the people who _use_ 
what you contributed, so that they can always say "but Twiinz signed off 
on it, he said that he will not sue my $ss off later, like this Darl 
b$stard".

So yes, I do worry.

Also, please do not top-post.

Hth,
Dscho

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> The Signed-off-by is not so much for _you_ as for the people who _use_ 
> what you contributed, so that they can always say "but Twiinz signed off 
> on it, he said that he will not sue my $ss off later, like this Darl 
> b$stard".
>
> So yes, I do worry.

It is not about him suing us, but more about "He certified that he did not
steal it from anywhere else", iow, other people suing us for what he did.

And we should worry.

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Shawn O. Pearce]

Junio C Hamano <gitster@pobox.com> wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > The Signed-off-by is not so much for _you_ as for the people who _use_ 
> > what you contributed, so that they can always say "but Twiinz signed off 
> > on it, he said that he will not sue my $ss off later, like this Darl 
> > b$stard".
> >
> > So yes, I do worry.
> 
> It is not about him suing us, but more about "He certified that he did not
> steal it from anywhere else", iow, other people suing us for what he did.
> 
> And we should worry.

In this case it is a very trivial patch.  Anyone who tries to do
the same thing is likely to come up with the same result, or one
that is close enough that it looks identical anyway.

Still, it isn't in my main tree, because it is lacking a proper
Signed-off-by tag by the original author.

-- 
Shawn.

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Twiinz]

On Thu, May 22, 2008 at 7:11 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> In this case it is a very trivial patch.  Anyone who tries to do
> the same thing is likely to come up with the same result, or one
> that is close enough that it looks identical anyway.
>
> Still, it isn't in my main tree, because it is lacking a proper
> Signed-off-by tag by the original author.

Sorry for the late response,

It's a very trivial patch, indeed.

I'm still a bit confused with those Signed-off-by things. Anyway I
sign hereby that:
- I coded those few lines myself
- I didn't steal them from anyone
- I'm not going to sue anybody over its utilization

If there's more that need to be done to get this patch approved please
point me to some online materials that detail the process.

I hope that helps,
/twiinz

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Shawn O. Pearce]

Twiinz <twiinz@gmail.com> wrote:
> On Thu, May 22, 2008 at 7:11 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > In this case it is a very trivial patch.  Anyone who tries to do
> > the same thing is likely to come up with the same result, or one
> > that is close enough that it looks identical anyway.
> >
> > Still, it isn't in my main tree, because it is lacking a proper
> > Signed-off-by tag by the original author.
> 
> Sorry for the late response,
> 
> It's a very trivial patch, indeed.
> 
> I'm still a bit confused with those Signed-off-by things. Anyway I
> sign hereby that:
> - I coded those few lines myself
> - I didn't steal them from anyone
> - I'm not going to sue anybody over its utilization

See "Sign your work" of git.git/Documentation/SubmittingPatches:

  http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;h=0e155c936c25255706bc6d47651c2b336c628417;hb=377d9c409ffe0f0d994b929aeb94716139207b9d

I think most reasonable people would say your statement has roughly
the same intent and effect as the Developer's Certificate of
Origin 1.1.
 
> If there's more that need to be done to get this patch approved please
> point me to some online materials that detail the process.
> 
> I hope that helps,

I'm going to edit your commit and add the signed off by line for you:

	Signed-off-by: Twiinz <twiinz@gmail.com>

Thanks.

-- 
Shawn.

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Twiinz]

On Thu, May 22, 2008 at 7:55 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> I'm going to edit your commit and add the signed off by line for you:
>
>        Signed-off-by: Twiinz <twiinz@gmail.com>

Thanks for your help Shawn.

I'll read that link you sent and I'll make sure next patch i
contribute has everything needed.

Cheers,
/twiinz

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Junio C Hamano]

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Junio C Hamano <gitster@pobox.com> wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>> > The Signed-off-by is not so much for _you_ as for the people who _use_ 
>> > what you contributed, so that they can always say "but Twiinz signed off 
>> > on it, he said that he will not sue my $ss off later, like this Darl 
>> > b$stard".
>> >
>> > So yes, I do worry.
>> 
>> It is not about him suing us, but more about "He certified that he did not
>> steal it from anywhere else", iow, other people suing us for what he did.
>> 
>> And we should worry.
>
> In this case it is a very trivial patch.

Yeah, I realized that I should have added that after sending the message.
I'd rather not to see a patch without S-o-b than with a S-o-b with a
phoney name, though.

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Shawn O. Pearce]

Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> > In this case it is a very trivial patch.
> 
> Yeah, I realized that I should have added that after sending the message.
> I'd rather not to see a patch without S-o-b than with a S-o-b with a
> phoney name, though.

Like this one?

  commit 2b36b146fa892a0a326eb2e35a39c9daf58fbe5e
  Author: A Large Angry SCM <gitzilla@gmail.com>
  Date:   Sat May 10 16:52:51 2008 -0400

    git-repack: re-enable parsing of -n command line option
    
    In commit 5715d0b (Migrate git-repack.sh to use git-rev-parse --parseopt,
    2007-11-04), parsing of the '-n' command line option was accidentally lost
    when git-repack.sh was migrated to use git-rev-parse --parseopt. This adds
    it back.
    
    Signed-off-by: A Large Angry SCM <gitzilla@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

;-)

Are we starting to make a submission policy that all contributions
need to have a non-phony looking name for the author line and
SBO?  We have not done so in the past, and we do not have the
infrastructure like The Eclipse Foundation has to require all
contributors to execute a (possibly enforceable) legal agreement
stating their contribution can be distributed under the GPLv2.

-- 
Shawn.

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

[Junio C Hamano]

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Junio C Hamano <gitster@pobox.com> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> > In this case it is a very trivial patch.
>> 
>> Yeah, I realized that I should have added that after sending the message.
>> I'd rather not to see a patch without S-o-b than with a S-o-b with a
>> phoney name, though.
>
> Like this one?

Sorry, your comparison is worse than apples-and-oranges.

Gitzilla was a relatively old-timer, already known entity in git circle
for quite some time, when we accepted that patch (also I think we know the
real name as well, check your local list archive).

In either case, that one and the one under discussion are both trivially
obvious changes and do not give us much worries.