From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rev-parse: teach "--verify" to be quiet when using "-q" or "--quiet"
Date: Sat, 26 Apr 2008 23:16:59 -0700 [thread overview]
Message-ID: <7vabjfizz8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080426135723.2b9e7c16.chriscool@tuxfamily.org> (Christian Couder's message of "Sat, 26 Apr 2008 13:57:23 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
> Currently "git rev-parse --verify <something>" is often used with
> its error output redirected to /dev/null. This patch makes it
> easier to do that.
>
> The -q|--quiet option is designed to work the same way as it does
> for "git symbolic-ref".
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> Documentation/git-rev-parse.txt | 5 +++++
> builtin-rev-parse.c | 20 ++++++++++++++++----
> 2 files changed, 21 insertions(+), 4 deletions(-)
>
> By the way it's strange that for example:
>
> $ git rev-parse --verify <good-rev> <junk>
>
> works whatever <junk> is, as long as <good-rev> can be
> parsed.
Very much so. The earlier plumbing programs tend to have this "works if
you give correct input but sometimes ignores bogosity" tendency. They are
loose not by design, and we should be able to tighten without worrying
about breaking existing scripts.
prev parent reply other threads:[~2008-04-27 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 11:57 [PATCH] rev-parse: teach "--verify" to be quiet when using "-q" or "--quiet" Christian Couder
2008-04-27 6:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabjfizz8.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).