git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Dan McGee <dpmcgee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow cherry-pick (and revert) to add signoff line
Date: Tue, 22 Apr 2008 22:08:07 -0700	[thread overview]
Message-ID: <7vabjlupjc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1208714585-4053-1-git-send-email-dpmcgee@gmail.com> (Dan McGee's message of "Sun, 20 Apr 2008 13:03:05 -0500")

Dan McGee <dpmcgee@gmail.com> writes:

> I often find myself pulling patches off of other peoples trees using
> cherry-pick, and following it with an immediate 'git commit --amend -s'
> command. Eliminate the need for a double commit by allowing signoff on a
> cherry-pick or revert.
>
> Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> ---
>
> This is something I have done in my workflow for a long time, and it seems
> like a weird omission to me. Signoffs can be done on git-am without having
> a second commit, and I often have a workflow where I am picking patches from
> other users' topic branches and have reviewed the patch and would like to
> signoff when I pull it into my tree.

Yeah, when your workflow is heavily rely on cherry-picking, I can see how
this would be handy.

I see there was some improvement suggestion suggested on the list, so I
will wait until the dust settles and I see an appliable final submission.

Thanks.

  parent reply	other threads:[~2008-04-23  5:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-20 18:03 [PATCH] Allow cherry-pick (and revert) to add signoff line Dan McGee
2008-04-20 18:28 ` Björn Steinbrink
2008-04-23  5:08 ` Junio C Hamano [this message]
2008-04-26 14:46   ` Dan McGee
2008-04-26 20:14     ` [PATCH resubmit] " Dan McGee
2008-04-26 21:07       ` Junio C Hamano
2008-04-27  0:43         ` [PATCH] Remove 'header' from --signoff option description Dan McGee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabjlupjc.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).