From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] pack-objects: Print a message describing the number of threads for packing Date: Tue, 26 Feb 2008 01:19:14 -0800 Message-ID: <7vablo848d.fsf@gitster.siamese.dyndns.org> References: <47B1BEC6.6080906@nrlssc.navy.mil> <1203732369-30314-1-git-send-email-casey@nrlssc.navy.mil> <47BF812A.4020205@nrlssc.navy.mil> <20080226074933.GA3485@coredump.intra.peff.net> <7vhcfwb116.fsf@gitster.siamese.dyndns.org> <20080226080634.GA4129@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Brandon Casey , Andreas Ericsson , Git Mailing List , Nicolas Pitre To: Jeff King X-From: git-owner@vger.kernel.org Tue Feb 26 10:20:23 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JTvz4-0002lK-DW for gcvg-git-2@gmane.org; Tue, 26 Feb 2008 10:20:22 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757516AbYBZJTk (ORCPT ); Tue, 26 Feb 2008 04:19:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757919AbYBZJTj (ORCPT ); Tue, 26 Feb 2008 04:19:39 -0500 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:46034 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753076AbYBZJTh (ORCPT ); Tue, 26 Feb 2008 04:19:37 -0500 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 6DF4721A5; Tue, 26 Feb 2008 04:19:31 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 66A3D21A4; Tue, 26 Feb 2008 04:19:22 -0500 (EST) User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Jeff King writes: > On Tue, Feb 26, 2008 at 12:00:05AM -0800, Junio C Hamano wrote: > >> >> + if (progress) >> >> + fprintf(stderr, "Using %d pack threads.\n", >> >> + delta_search_threads); >> > >> > I just noticed that this was in next. >> >> Please send in a fix-up patch to remove it. I noticed it while >> reviewing the patch, and even commented on it, but I somehow >> forgot that this leftover debugging message disqualified the >> series from 'next' when I was merging topics to 'next'. > > Are you sure you are thinking of the same message? Ah, no. But now you mention it, I tend to agree with you. This is primarily of interest for git developers and I do not think the end users would care. Maybe under --verbose or --debug option (but I do not think we have --debug option anywhere).