From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] Export some email and pretty-printing functions
Date: Sun, 17 Feb 2008 19:45:07 -0800 [thread overview]
Message-ID: <7vablzudvg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LNX.1.00.0802171335460.5816@iabervon.org
Daniel Barkalow <barkalow@iabervon.org> writes:
> +void add_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb,
> + const char *line, enum date_mode dmode,
> + const char *encoding);
Exactly the same comment about "the function name being too
generic" from the last round still applies.
next prev parent reply other threads:[~2008-02-18 3:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 18:35 [PATCH 2/4] Export some email and pretty-printing functions Daniel Barkalow
2008-02-18 3:45 ` Junio C Hamano [this message]
2008-02-18 17:00 ` Daniel Barkalow
2008-02-18 12:44 ` Johannes Schindelin
2008-02-18 19:07 ` Daniel Barkalow
2008-02-18 22:24 ` Daniel Barkalow
-- strict thread matches above, loose matches on Subject: below --
2008-02-06 16:43 Daniel Barkalow
2008-02-06 20:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vablzudvg.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).