From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 2/4] Export some email and pretty-printing functions Date: Sun, 17 Feb 2008 19:45:07 -0800 Message-ID: <7vablzudvg.fsf@gitster.siamese.dyndns.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: Daniel Barkalow X-From: git-owner@vger.kernel.org Mon Feb 18 04:46:07 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQwxB-00012m-5F for gcvg-git-2@gmane.org; Mon, 18 Feb 2008 04:46:05 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752201AbYBRDp3 (ORCPT ); Sun, 17 Feb 2008 22:45:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751276AbYBRDp3 (ORCPT ); Sun, 17 Feb 2008 22:45:29 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:34693 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbYBRDp2 (ORCPT ); Sun, 17 Feb 2008 22:45:28 -0500 Received: from a-sasl-quonix.pobox.com (localhost [127.0.0.1]) by a-sasl-quonix.pobox.com (Postfix) with ESMTP id 79CD855FD; Sun, 17 Feb 2008 22:45:26 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-quonix.pobox.com (Postfix) with ESMTP id 06A7355FC; Sun, 17 Feb 2008 22:45:23 -0500 (EST) User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Daniel Barkalow writes: > +void add_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb, > + const char *line, enum date_mode dmode, > + const char *encoding); Exactly the same comment about "the function name being too generic" from the last round still applies.