* [PATCH] http.c: guard config parser from value=NULL
@ 2008-02-09 0:39 Govind Salinas
2008-02-09 17:46 ` Christian Couder
2008-02-09 21:09 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: Govind Salinas @ 2008-02-09 0:39 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano
Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>
---
http.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/http.c b/http.c
index d2c11ae..0a2c1c8 100644
--- a/http.c
+++ b/http.c
@@ -92,6 +92,9 @@ static void process_curl_messages(void)
static int http_options(const char *var, const char *value)
{
+ if (!value)
+ return git_default_config(var, value);
+
if (!strcmp("http.sslverify", var)) {
if (curl_ssl_verify == -1) {
curl_ssl_verify = git_config_bool(var, value);
--
1.5.4.36.g9af61
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] http.c: guard config parser from value=NULL
2008-02-09 0:39 [PATCH] http.c: guard config parser from value=NULL Govind Salinas
@ 2008-02-09 17:46 ` Christian Couder
2008-02-09 21:09 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Christian Couder @ 2008-02-09 17:46 UTC (permalink / raw)
To: Govind Salinas; +Cc: Git Mailing List, Junio C Hamano
Le samedi 9 février 2008, Govind Salinas a écrit :
> Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>
> ---
> http.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/http.c b/http.c
> index d2c11ae..0a2c1c8 100644
> --- a/http.c
> +++ b/http.c
> @@ -92,6 +92,9 @@ static void process_curl_messages(void)
>
> static int http_options(const char *var, const char *value)
> {
> + if (!value)
> + return git_default_config(var, value);
> +
> if (!strcmp("http.sslverify", var)) {
> if (curl_ssl_verify == -1) {
> curl_ssl_verify = git_config_bool(var, value);
After a very quick look at this, it seems that no change is needed here
because 'git_config_bool' handles a NULL value correctly. Some changes may
be needed below though.
Thanks,
Christian.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] http.c: guard config parser from value=NULL
2008-02-09 0:39 [PATCH] http.c: guard config parser from value=NULL Govind Salinas
2008-02-09 17:46 ` Christian Couder
@ 2008-02-09 21:09 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2008-02-09 21:09 UTC (permalink / raw)
To: Govind Salinas; +Cc: Git Mailing List
"Govind Salinas" <blix@sophiasuchtig.com> writes:
> Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>
> ---
> http.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/http.c b/http.c
> index d2c11ae..0a2c1c8 100644
> --- a/http.c
> +++ b/http.c
> @@ -92,6 +92,9 @@ static void process_curl_messages(void)
>
> static int http_options(const char *var, const char *value)
> {
> + if (!value)
> + return git_default_config(var, value);
> +
> if (!strcmp("http.sslverify", var)) {
> if (curl_ssl_verify == -1) {
> curl_ssl_verify = git_config_bool(var, value);
I think this patch is wrong.
You just broke existing repositories with:
[http]
sslverify
to set it to true.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-09 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-09 0:39 [PATCH] http.c: guard config parser from value=NULL Govind Salinas
2008-02-09 17:46 ` Christian Couder
2008-02-09 21:09 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).