From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-relink.perl: warn() instead of die() on directory open failure
Date: Fri, 11 Jan 2008 18:14:18 -0800 [thread overview]
Message-ID: <7vabnbzt6t.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <4787B15D.3070105@nrlssc.navy.mil> (Brandon Casey's message of "Fri, 11 Jan 2008 12:11:41 -0600")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>
>
> Sometimes the repository to link to is not under your control.
> If it contains files or unreadable directories, git-relink will
> die without this patch.
I am not so sure if dying is a bad behaviour, if it is because
you are trying to link against an object store that you may not
be able to read. I actually think we should actively refuse to,
in order to prevent future problems. After seeing the command
die, you will talk to the owner of that "master" object store
and ask him to fix permissions (or he may choose to say "please
do not share with me").
However, if the "master" object store has pruned its loose
objects since you read @hashdirs out of it, that opendir() can
fail, and we should silently ignore the whole $subdir.
next prev parent reply other threads:[~2008-01-12 2:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 18:11 [PATCH] git-relink.perl: warn() instead of die() on directory open failure Brandon Casey
2008-01-12 2:14 ` Junio C Hamano [this message]
2008-01-12 2:26 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabnbzt6t.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox