git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Arjen Laarhoven <arjen@yaph.org>
Subject: Re: [PATCH] Test "git log --diff-filter"
Date: Sun, 06 Jan 2008 17:58:22 -0800	[thread overview]
Message-ID: <7vabni2y81.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200801070131.57722.jnareb@gmail.com> (Jakub Narebski's message of "Mon, 7 Jan 2008 01:31:56 +0100")

Jakub Narebski <jnareb@gmail.com> writes:

> Am I mistaken in thinking that the rest of git always use terminators,
> and not separators for records output?

Actually, for normal "git log", separator semantics is the right
thing to use.  You do not want to add an additional trailing
newline when you show only one.  Compare these two to see what I
mean:

	$ git log -1
        $ git log -2

The problem is with --pretty=format.

        

      reply	other threads:[~2008-01-07  1:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-25 11:06 [PATCH] Fix "git log --diff-filter" bug Arjen Laarhoven
2007-12-25 22:44 ` Jakub Narebski
2007-12-26 19:41 ` Junio C Hamano
2008-01-05 22:20 ` [PATCH] Test "git log --diff-filter" Jakub Narebski
2008-01-05 22:34   ` Junio C Hamano
2008-01-05 23:33     ` Jakub Narebski
2008-01-06  2:26       ` Junio C Hamano
2008-01-07  0:31         ` Jakub Narebski
2008-01-07  1:58           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabni2y81.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=arjen@yaph.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).