From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] Use regex for :/ matching
Date: Wed, 05 Dec 2007 22:33:49 -0800 [thread overview]
Message-ID: <7vaboogwmq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071206055200.GA23309@coredump.intra.peff.net> (Jeff King's message of "Thu, 6 Dec 2007 00:52:00 -0500")
Jeff King <peff@peff.net> writes:
> Obviously the overall design and usage of :/ is going to take some
> thinking and is not 1.5.4 material. However, we do have it in its
> current form, and I think regex versus prefix string matching is
> orthogonal to the range issues. Should I post my rebased :/ regex patch,
> or do you want to just leave it for post-1.5.4?
Making what was string match to regex using the same syntax is a
regression, isn't it? I do not use :/ very often myself, so I
personally would not mind but people who are used to using :/ may get
upset about the change. I do not feel strongly enough for changing it
to regex to declare such a change unilaterally.
next prev parent reply other threads:[~2007-12-06 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 4:32 [PATCH/RFC] Use regex for :/ matching Jeff King
2007-12-03 10:55 ` Johannes Schindelin
2007-12-03 17:30 ` Jeff King
2007-12-03 18:17 ` Junio C Hamano
2007-12-06 5:52 ` Jeff King
2007-12-06 6:33 ` Junio C Hamano [this message]
2007-12-06 6:39 ` Jeff King
2007-12-06 12:13 ` Johannes Schindelin
2007-12-03 18:42 ` [PATCH] Allow ':/<oneline-prefix>' syntax to work with save_commit_buffer == 0 Johannes Schindelin
2007-12-03 21:34 ` Junio C Hamano
2007-12-03 22:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaboogwmq.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).