git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andreas Ericsson <ae@op5.se>
Cc: Pascal Obry <pascal.obry@wanadoo.fr>,
	Pascal Obry <pascal@obry.net>,
	Pascal Obry <pascal.obry@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Date: Tue, 04 Dec 2007 13:59:33 -0800	[thread overview]
Message-ID: <7vaboq3yuy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7v63ze5osn.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 04 Dec 2007 09:54:00 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Andreas Ericsson <ae@op5.se> writes:
>
>> Nice. If my suspicions are correct and he missed your patch the first time
>> around, you should probably resend it though.
>
> I still have it in my mailbox.
>
> I saw the patch but saw nobody else said about the patch being helpful
> to his installation, nor more importantly, "Good, this won't hurt for me
> who run a different vintage of Cygwin", and I was waiting for such
> confirmations.
>
> Then nobody responded, so I forgot.
>
> That was what happened the first time Pascal's patch was posted.

I think the patch is fine; I just checked with my copy of Cygwin that I
haven't fired for some time (it was a pain waiting for it to update to
the latest set of git sources).

I am at work and will be busy for the rest of the afternoon, so won't be
applying it until this evening, though.

  reply	other threads:[~2007-12-04 22:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-04 13:39 [PATCH] Set OLD_ICONV on Cygwin Pascal Obry
2007-12-04 13:43 ` Andreas Ericsson
2007-12-04 17:54   ` Junio C Hamano
2007-12-04 21:59     ` Junio C Hamano [this message]
2007-12-04 22:12       ` Pascal Obry
  -- strict thread matches above, loose matches on Subject: below --
2007-12-01  9:49 Pascal Obry
2007-12-03 18:49 ` Pascal Obry
2007-12-04  9:32   ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vaboq3yuy.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=pascal.obry@gmail.com \
    --cc=pascal.obry@wanadoo.fr \
    --cc=pascal@obry.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).