From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Make builtin-tag.c use parse_options. Date: Fri, 09 Nov 2007 22:07:37 -0800 Message-ID: <7vabpmpr9y.fsf@gitster.siamese.dyndns.org> References: <473463E0.7000406@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: Carlos Rica X-From: git-owner@vger.kernel.org Sat Nov 10 07:08:28 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IqjW6-00063U-7P for gcvg-git-2@gmane.org; Sat, 10 Nov 2007 07:08:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbXKJGHo (ORCPT ); Sat, 10 Nov 2007 01:07:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751687AbXKJGHn (ORCPT ); Sat, 10 Nov 2007 01:07:43 -0500 Received: from sceptre.pobox.com ([207.106.133.20]:52934 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbXKJGHm (ORCPT ); Sat, 10 Nov 2007 01:07:42 -0500 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 5EEB42F2; Sat, 10 Nov 2007 01:08:03 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 9358A914B4; Sat, 10 Nov 2007 01:08:00 -0500 (EST) In-Reply-To: <473463E0.7000406@gmail.com> (Carlos Rica's message of "Fri, 09 Nov 2007 14:42:56 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Carlos Rica writes: > Also, this removes those tests ensuring that repeated > -m options don't allocate memory more than once, because now > this is done after parsing options, using the last one > when more are given. The same for -F. The reason for this change is...? Is this because it is cumbersome to detect and refuse multiple -m options using the parseopt API? If so, the API may be what needs to be fixed. Taking the last one and discarding earlier ones feels to me an arbitrary choice. While I freely admit that I do not particularly find the "One -m introduces one new line, concatenated to form the final paragraph" handling of multiple -m options done by git-commit nice nor useful, I suspect that it would make more sense to make git-tag and git-commit handle multiple -m option consistently, if you are going to change the existing semantics. Since some people really seem to like multiple -m handling of git-commit, the avenue of the least resistance for better consistency would be to accept and concatenate (with LF in between) multiple -m options. With multiple -F, I think erroring out would be the sensible thing to do, but some people might prefer concatenation. I do not care either way as long as commit and tag behave consistently.