git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: Alex Riesen <raa.lkml@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] t3502: Disambiguate between file and rev by adding --
Date: Mon, 05 Nov 2007 17:20:11 -0800	[thread overview]
Message-ID: <7vabpskw50.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <2DC3CFEE-ACA0-448F-9957-EB98F299D812@silverinsanity.com> (Brian Gernhardt's message of "Mon, 5 Nov 2007 20:17:27 -0500")

Brian Gernhardt <benji@silverinsanity.com> writes:

> On Nov 5, 2007, at 5:25 PM, Alex Riesen wrote:
>
>> Brian Gernhardt, Sun, Nov 04, 2007 16:31:26 +0100:
>>> This test failed because git-diff didn't know if it was asking for
>>> the
>>> file "a" or the branch "a".  Adding "--" at the end of the ambiguous
>>> commands allows the test to finish properly.
>>
>> To be precise: this is ambiguous only on case-challenged filesystems
>
> Oh.  I just saw the ambiguous error.  Should I re-post with a more
> correct commit message?

This is what I wrote but haven't pushed out (I will have to tend
other topics first):

commit 9f12bec4386fc96e5b617268822cbb75e4c76101
Author: Brian Gernhardt <benji@silverinsanity.com>
Date:   Sun Nov 4 10:31:26 2007 -0500

    t3502: Disambiguate between file and rev by adding --
    
    On a case insensitive file system, this test fails because git-diff
    doesn't know if it is asking for the file "A" or the tag "a".
    
    Adding "--" at the end of the ambiguous commands allows the test to
    finish properly.
    
    Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

      reply	other threads:[~2007-11-06  1:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-04 15:31 [PATCH] t3502: Disambiguate between file and rev by adding -- Brian Gernhardt
2007-11-05 22:25 ` Alex Riesen
2007-11-06  1:17   ` Brian Gernhardt
2007-11-06  1:20     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabpskw50.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).