From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow 'git blame rev path' to work on bare repository
Date: Sat, 03 Nov 2007 22:21:53 -0700 [thread overview]
Message-ID: <7vabpuvb4e.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1194092575-7133-2-git-send-email-mh@glandium.org> (Mike Hommey's message of "Sat, 3 Nov 2007 13:22:54 +0100")
Mike Hommey <mh@glandium.org> writes:
> While 'git blame rev -- path' works, 'git blame rev path' didn't.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
> builtin-blame.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/builtin-blame.c b/builtin-blame.c
> index aedc294..141287e 100644
> --- a/builtin-blame.c
> +++ b/builtin-blame.c
> @@ -2294,10 +2294,6 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
> }
> else if (i != argc - 1)
> usage(blame_usage); /* garbage at end */
> -
> - if (!has_path_in_work_tree(path))
> - die("cannot stat path %s: %s",
> - path, strerror(errno));
> }
> }
>
Sorry but a NAK; at least limit the removal of the test only to a bare
repository case.
next prev parent reply other threads:[~2007-11-04 5:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 12:22 [PATCH] Delay pager setup in git blame Mike Hommey
2007-11-03 12:22 ` [PATCH] Allow 'git blame rev path' to work on bare repository Mike Hommey
2007-11-03 12:22 ` [PATCH] Make git-blame fail when working tree is needed and we're not in one Mike Hommey
2007-11-03 12:30 ` Mike Hommey
2007-11-03 15:01 ` Andreas Ericsson
2007-11-04 5:21 ` Junio C Hamano [this message]
2007-11-04 8:26 ` [PATCH] Allow 'git blame rev path' to work on bare repository Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabpuvb4e.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).