git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Dmitry Potapov" <dpotapov@gmail.com>,
	"Karl Hasselström" <kha@treskal.com>,
	"Björn Steinbrink" <B.Steinbrink@gmx.de>,
	Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH 1/1] Add --first-parent support to interactive rebase.
Date: Wed, 31 Oct 2007 21:10:30 -0700	[thread overview]
Message-ID: <7vabpyfvwp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071101032303.GA14495@coredump.intra.peff.net> (Jeff King's message of "Wed, 31 Oct 2007 23:23:03 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Oct 31, 2007 at 03:31:20PM -0700, Junio C Hamano wrote:
>
>> > ... I had one concern that
>> > I was tracking down: is the author name encoding necessarily the same as
>> > the commit text encoding?
>> 
>> The user is screwing himself already if that is the case and
>> uses -s to format-patch, isn't he?
>
> Hrm, they probably _should_ be the same in the output. It's not clear to
> me what encoding we assume the name comes in (utf-8, I guess). Looks
> like we don't touch it at all when putting it in the signoff. I think we
> should just be able to reencode when appending the signoff; patch is
> below.

I think assuming utf-8 and reencoding is actively wrong.
Existing setups of people with names that cannot be expressed in
ASCII would already have the commit encoding specified in the
configuration and user.name stored in that encoding, so passing
things through as we have always done is the right thing to do.

  reply	other threads:[~2007-11-01  4:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31  2:21 [PATCH 1/1] Add --first-parent support to interactive rebase Björn Steinbrink
2007-10-31  3:34 ` Johannes Schindelin
2007-10-31  4:17   ` Björn Steinbrink
2007-10-31  4:50     ` Johannes Schindelin
2007-10-31  8:24     ` Wincent Colaiuta
2007-10-31  5:05 ` Junio C Hamano
2007-10-31  5:53   ` Björn Steinbrink
2007-10-31 13:43     ` Dmitry Potapov
2007-10-31 14:00       ` Karl Hasselström
2007-10-31 14:36         ` Dmitry Potapov
2007-10-31 18:05           ` Jeff King
2007-10-31 19:50             ` Björn Steinbrink
2007-10-31 21:53             ` Junio C Hamano
2007-10-31 21:56               ` Jeff King
2007-10-31 22:31                 ` Junio C Hamano
2007-11-01  3:23                   ` Jeff King
2007-11-01  4:10                     ` Junio C Hamano [this message]
2007-11-01  4:14                       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabpyfvwp.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=B.Steinbrink@gmx.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=dpotapov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).