From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: stimming@tuhh.de, spearce@spearce.org, git@vger.kernel.org
Subject: Re: [GIT-GUI PATCH 2/3] po2msg: ignore untranslated messages
Date: Tue, 30 Oct 2007 12:27:52 -0700 [thread overview]
Message-ID: <7vabq0l7wn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710301124450.4362@racer.site> (Johannes Schindelin's message of "Tue, 30 Oct 2007 11:24:53 +0000 (GMT)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Do not generate translations when the translated message is empty.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> po/po2msg.sh | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/po/po2msg.sh b/po/po2msg.sh
> index 48a2669..91d420b 100644
> --- a/po/po2msg.sh
> +++ b/po/po2msg.sh
> @@ -62,6 +62,9 @@ proc flush_msg {} {
> if {$msgid == ""} {
> set prefix "set ::msgcat::header"
> } else {
> + if {$msgstr == ""} {
> + return
> + }
> set prefix "::msgcat::mcset $lang \"[u2a $msgid]\""
> }
Is this change to fix some real issues?
Sometimes it is handy to be able to translate a non-empty string
into an empty one in one target language.
next prev parent reply other threads:[~2007-10-30 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 11:24 [GIT-GUI PATCH 0/3] po2msg fixes Johannes Schindelin
2007-10-30 11:24 ` [GIT-GUI PATCH 1/3] po2msg: ignore entries marked with "fuzzy" Johannes Schindelin
2007-10-30 11:24 ` [GIT-GUI PATCH 2/3] po2msg: ignore untranslated messages Johannes Schindelin
2007-10-30 19:27 ` Junio C Hamano [this message]
2007-10-30 20:44 ` Christian Stimming
2007-10-31 2:23 ` Johannes Schindelin
2007-10-30 11:25 ` [GIT-GUI PATCH 3/3] po2msg: actually output statistics Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabq0l7wn.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=stimming@tuhh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).