From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Pierre Habouzit <madcoder@debian.org>
Subject: size_t vs "unsigned long"
Date: Wed, 03 Oct 2007 13:30:04 -0700 [thread overview]
Message-ID: <7vabr0djqr.fsf@gitster.siamese.dyndns.org> (raw)
Traditionally, inside git, we have used the length of things
with "unsigned long" for pretty much anything, except where we
wanted the length exactly sized we used int32_t, uint64_t and
friends.
A few places pass pointer to unsigned long as the second
parameter to strbuf_detach(), triggering type mismatch warnings.
An easy way out is to change strbuf_detach() to take a pointer
to ulong but I think it is going backwards. Most places that
use "unsigned long" can safely be converted (and made more
correct) to use size_t.
Any opinions?
next reply other threads:[~2007-10-03 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 20:30 Junio C Hamano [this message]
2007-10-03 20:48 ` size_t vs "unsigned long" Pierre Habouzit
2007-10-03 21:05 ` Junio C Hamano
2007-10-03 21:19 ` Jan Wielemaker
2007-10-03 21:36 ` Pierre Habouzit
2007-10-04 7:16 ` Jan Wielemaker
2007-10-03 21:36 ` Florian Weimer
2007-10-05 6:27 ` Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabr0djqr.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).