Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Yasushi SHOJI <yashi@atmark-techno.com>, git@vger.kernel.org
Subject: Re: [PATCH] describe: Add unlisted option
Date: Mon, 23 Jul 2007 00:41:13 -0700	[thread overview]
Message-ID: <7vabtnmusm.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070723070308.GH32566@spearce.org> (Shawn O. Pearce's message of "Mon, 23 Jul 2007 03:03:08 -0400")

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Yasushi SHOJI <yashi@atmark-techno.com> wrote:
>> added unlisted options, --contains, --candidates and --debug, to usage
>> line.  also, prints some info when --contains and --debug are given.
>
> That makes sense.  Especially telling the user why --debug --contains
> doesn't actually print anything.  ;-)
>
> Originally I left out --candidates and --debug when I wrote the code
> for them as I thought they were a tad too internal for casual use.
> But maybe it makes sense to include them in the usage string.

I was actually going to suggest removing these options, that
were primarily meant for debugging and tweaking while we figure
out what the optimum default should be.  Do you think they are
worth keeping?

  reply	other threads:[~2007-07-23  7:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-23  6:24 [PATCH] describe: Add unlisted option Yasushi SHOJI
2007-07-23  7:03 ` Shawn O. Pearce
2007-07-23  7:41   ` Junio C Hamano [this message]
2007-07-23  7:47     ` Shawn O. Pearce
2007-07-23  8:54       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabtnmusm.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=yashi@atmark-techno.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox