Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Jeff King <peff@peff.net>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: pass --no-left-right to rev-list
Date: Tue, 19 Dec 2006 02:28:31 -0800	[thread overview]
Message-ID: <7vac1krxgw.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20061219100534.GA9206@coredump.intra.peff.net> (Jeff King's message of "Tue, 19 Dec 2006 05:05:35 -0500")

Jeff King <peff@peff.net> writes:

> I think there are three fixes:
>   1. this patch (avoid using left-right)
>   2. gitk can detect and parse the new format
>   3. revert automatic use of left-right
> The third makes the most sense to me.

1. has the problem that it requires the version of Porcelains
and the core to be tightly linked.  2. is nice but unnecessary
burden in the short term.  3. does not break things for anybody,
but if left-right output is useful on the terminal, it burdens
the end-user typing from the command line.

So in the longer term, 2 is probably slightly more preferrable,
but my philosophy is "do not change anything unless absolutely
necessary", so 3 is also sensible, at least in the short term.

Thanks for catching this quickly, before it hit the master.
Let's revert 57612319.

  reply	other threads:[~2006-12-19 10:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-19 10:05 [PATCH] gitk: pass --no-left-right to rev-list Jeff King
2006-12-19 10:28 ` Junio C Hamano [this message]
2006-12-19 10:47 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vac1krxgw.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox