From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: git 0.99.7b doesn't build on Cygwin
Date: Fri, 23 Sep 2005 20:04:54 -0700 [thread overview]
Message-ID: <7vaci36u95.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0509231935360.3308@g5.osdl.org> (Linus Torvalds's message of "Fri, 23 Sep 2005 19:46:47 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> Looking a bit closer at the diff() usage, I actually think that we could
> move the fork() closer to the exec - we'd just have to move it _into_ all
> the different cases (ie you'd have two different fork() calls: one for
> the "builtin" case, one for the external pgm case, but then the child in
> both cases would be very simple).
Looking back at what I did in the diff.c, I actually think the
part near fork() is a total crap ;-).
Originally I intended to do more work in the child process (this
is totally opposite of what is being proposed now), for example
running prepare_temp_file() after child forked, so that the
parent process does not have to worry about using memory for
expanded blob to be written out to the temporary file and then
later forgetting to free it ;-), but it seems the parent is
doing more work than I intended to. I honestly think that the
part of the code is ancient enough to deserve a major facelift.
next prev parent reply other threads:[~2005-09-24 3:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 13:33 git 0.99.7b doesn't build on Cygwin Peter TB Brett
2005-09-23 13:44 ` Johannes Schindelin
2005-09-23 13:50 ` Peter TB Brett
2005-09-23 22:08 ` Martin Langhoff
2005-09-23 22:34 ` Petr Baudis
2005-09-24 0:09 ` Linus Torvalds
2005-09-24 0:43 ` Linus Torvalds
2005-09-25 7:52 ` Junio C Hamano
2005-09-25 15:47 ` Implementing diff, was " Johannes Schindelin
2005-09-25 16:08 ` Davide Libenzi
2005-09-25 17:00 ` Linus Torvalds
2005-09-25 19:16 ` Davide Libenzi
2005-09-24 1:13 ` Johannes Schindelin
2005-09-24 2:46 ` Linus Torvalds
2005-09-24 3:04 ` Junio C Hamano [this message]
2005-09-24 5:26 ` Davide Libenzi
2005-09-24 18:10 ` Linus Torvalds
2005-09-24 19:12 ` Davide Libenzi
2005-09-24 20:31 ` Junio C Hamano
2005-09-24 21:28 ` Davide Libenzi
2005-09-24 21:46 ` Junio C Hamano
2005-09-24 21:47 ` Junio C Hamano
2005-09-24 21:52 ` Davide Libenzi
2005-09-24 22:26 ` Linus Torvalds
2005-09-24 22:27 ` Linus Torvalds
2005-09-25 16:59 ` Linus Torvalds
2005-09-26 19:33 ` Jon Loeliger
2005-09-26 20:23 ` Junio C Hamano
2005-09-24 22:41 ` Davide Libenzi
2005-09-25 19:59 ` Giuseppe Bilotta
2005-09-26 4:57 ` Junio C Hamano
2005-09-26 5:05 ` Davide Libenzi
2005-09-26 11:00 ` Giuseppe Bilotta
2005-09-26 21:54 ` H. Peter Anvin
2005-09-26 22:03 ` Davide Libenzi
2005-09-26 22:15 ` H. Peter Anvin
2005-09-25 3:04 ` Daniel Barkalow
2005-09-24 5:11 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaci36u95.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).