From: Junio C Hamano <junkio@cox.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] Fix fetch completeness assumptions
Date: Sat, 17 Sep 2005 01:32:06 -0700 [thread overview]
Message-ID: <7vacicccxl.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vhdckceas.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Sat, 17 Sep 2005 01:02:35 -0700")
Junio C Hamano <junkio@cox.net> writes:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
>> Don't assume that any commit we have is complete; assume that any ref
>> we have is complete.
>
> Have you tested this idea with cloning into an empty repository?
> It seems to break my tests.
Sorry, I spoke too fast. This is not _broken_ per se, but is
just slow.
I tried to clone http://kernel.org/pub/scm/git.git/; bulk of the
objects are packed there but the new code is _too_ cautious,
since it did not have any refs to begin with, it ended up
walking the commits in the already downloaded packs to the root.
next prev parent reply other threads:[~2005-09-17 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 1:31 [PATCH] Fix fetch completeness assumptions Daniel Barkalow
2005-09-15 8:09 ` Junio C Hamano
2005-09-15 16:42 ` Daniel Barkalow
2005-09-15 11:02 ` Sergey Vlasov
2005-09-15 16:54 ` Daniel Barkalow
2005-09-16 6:04 ` Junio C Hamano
2005-09-17 8:02 ` Junio C Hamano
2005-09-17 8:32 ` Junio C Hamano [this message]
2005-09-17 8:50 ` Help cloning over http Junio C Hamano
2005-09-17 17:37 ` Daniel Barkalow
2005-09-18 17:38 ` [PATCH] Improve the safety check used in fetch.c Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vacicccxl.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).