git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, git@vger.kernel.org
Subject: Re: [PATCH] Teach applymbox to keep the Subject: line.
Date: Thu, 18 Aug 2005 18:04:53 -0700	[thread overview]
Message-ID: <7vacjeenyi.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: Pine.LNX.4.58.0508181257320.3412@g5.osdl.org

Linus Torvalds <torvalds@osdl.org> writes:

> Well, Junio has been talking about adding commit hooks. I don't think
> that's been done.

No, notyet.  But tonight.

> The only question is what the hook/trigger should look like. just put
> something like
>
> 	[ -x .git/hooks/applypatch-hook ] &&
> 	     .git/hooks/applypatch-hook "$tree" "$PATCHFILE" || exit
>
> at the line before that "git-apply" perhaps? Then, you could install your 
> own applypatch hook which looks at the message or the patch?

Sounds sensible.  The hook would probably want a handy access to
the commit object as well to catch:

     - the author name may be spelled wrong or has funky
       B-encodings still left.

     - some people might want to even run spellchecker on the
       commit message.

     - lack of S-O-B line.

  reply	other threads:[~2005-08-19  1:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-16 21:47 [RFC] Patches exchange is bad? Marco Costalba
2005-08-16 22:31 ` [PATCH] git-format-patch fix Junio C Hamano
2005-08-17  5:47   ` [PATCH] Teach applymbox to keep the Subject: line Junio C Hamano
2005-08-17 15:38     ` Linus Torvalds
2005-08-18 17:26       ` Sam Ravnborg
2005-08-18 20:07         ` Linus Torvalds
2005-08-19  1:04           ` Junio C Hamano [this message]
2005-08-19 21:41           ` [PATCH] Add hooks to tools/git-applypatch Junio C Hamano
2005-08-19  1:04         ` [PATCH] Teach applymbox to keep the Subject: line Junio C Hamano
2005-08-17 17:36     ` Jeff Garzik
2005-08-17 19:26       ` Junio C Hamano
2005-08-17 19:56       ` Linus Torvalds
2005-08-17 20:42         ` Junio C Hamano
2005-08-17 21:36         ` Johannes Schindelin
2005-08-18 10:32         ` David Kågedal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vacjeenyi.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).