* [PATCH] diff-options: document default similarity index
@ 2013-06-24 11:17 Fraser Tweedale
2013-06-24 16:27 ` Ramkumar Ramachandra
0 siblings, 1 reply; 5+ messages in thread
From: Fraser Tweedale @ 2013-06-24 11:17 UTC (permalink / raw)
To: git; +Cc: Fraser Tweedale
The default similarity index of 50% is documented in gitdiffcore(7)
but it is worth also mentioning it in the description of the
-M/--find-renames option.
Signed-off-by: Fraser Tweedale <frase@frase.id.au>
---
Documentation/diff-options.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
index b8a9b86..69bb3a6 100644
--- a/Documentation/diff-options.txt
+++ b/Documentation/diff-options.txt
@@ -333,7 +333,7 @@ endif::git-log[]
a fraction, with a decimal point before it. I.e., `-M5` becomes
0.5, and is thus the same as `-M50%`. Similarly, `-M05` is
the same as `-M5%`. To limit detection to exact renames, use
- `-M100%`.
+ `-M100%`. The default similarity index is 50%.
-C[<n>]::
--find-copies[=<n>]::
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] diff-options: document default similarity index
2013-06-24 11:17 Fraser Tweedale
@ 2013-06-24 16:27 ` Ramkumar Ramachandra
0 siblings, 0 replies; 5+ messages in thread
From: Ramkumar Ramachandra @ 2013-06-24 16:27 UTC (permalink / raw)
To: Fraser Tweedale; +Cc: git
Fraser Tweedale wrote:
> The default similarity index of 50% is documented in gitdiffcore(7)
> but it is worth also mentioning it in the description of the
> -M/--find-renames option.
Looks good from a quick look at diffcore.h:
#define DEFAULT_RENAME_SCORE 30000 /* rename/copy similarity minimum (50%) */
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] diff-options: document default similarity index
@ 2013-07-05 8:42 Fraser Tweedale
2013-07-05 9:00 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Fraser Tweedale @ 2013-07-05 8:42 UTC (permalink / raw)
To: gitster; +Cc: git, Fraser Tweedale
The default similarity index of 50% is documented in gitdiffcore(7)
but it is worth also mentioning it in the description of the
-M/--find-renames option.
Signed-off-by: Fraser Tweedale <frase@frase.id.au>
---
Documentation/diff-options.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
index a85288f..d6e4db4 100644
--- a/Documentation/diff-options.txt
+++ b/Documentation/diff-options.txt
@@ -333,7 +333,7 @@ endif::git-log[]
a fraction, with a decimal point before it. I.e., `-M5` becomes
0.5, and is thus the same as `-M50%`. Similarly, `-M05` is
the same as `-M5%`. To limit detection to exact renames, use
- `-M100%`.
+ `-M100%`. The default similarity index is 50%.
-C[<n>]::
--find-copies[=<n>]::
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] diff-options: document default similarity index
2013-07-05 8:42 [PATCH] diff-options: document default similarity index Fraser Tweedale
@ 2013-07-05 9:00 ` Junio C Hamano
2013-07-05 10:00 ` Fraser Tweedale
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2013-07-05 9:00 UTC (permalink / raw)
To: Fraser Tweedale; +Cc: git
Fraser Tweedale <frase@frase.id.au> writes:
> The default similarity index of 50% is documented in gitdiffcore(7)
> but it is worth also mentioning it in the description of the
> -M/--find-renames option.
Is it? I am not sure if it is worth it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] diff-options: document default similarity index
2013-07-05 9:00 ` Junio C Hamano
@ 2013-07-05 10:00 ` Fraser Tweedale
0 siblings, 0 replies; 5+ messages in thread
From: Fraser Tweedale @ 2013-07-05 10:00 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Fri, Jul 05, 2013 at 02:00:40AM -0700, Junio C Hamano wrote:
> Fraser Tweedale <frase@frase.id.au> writes:
>
> > The default similarity index of 50% is documented in gitdiffcore(7)
> > but it is worth also mentioning it in the description of the
> > -M/--find-renames option.
>
> Is it? I am not sure if it is worth it.
The -M description goes on at some length to explain how to specify
a particular value. Surely a brief mention of the default value is
also warranted, especially since the pointer to gitdiffcore(7) for a
more detailed explanation of the options appears quite a way below.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-05 10:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-05 8:42 [PATCH] diff-options: document default similarity index Fraser Tweedale
2013-07-05 9:00 ` Junio C Hamano
2013-07-05 10:00 ` Fraser Tweedale
-- strict thread matches above, loose matches on Subject: below --
2013-06-24 11:17 Fraser Tweedale
2013-06-24 16:27 ` Ramkumar Ramachandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).