From: Junio C Hamano <gitster@pobox.com>
To: Johan Herland <johan@herland.net>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: Storing refs in the odb
Date: Mon, 20 May 2013 10:21:10 -0700 [thread overview]
Message-ID: <7vbo85wos9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALKQrgcBkdoJdJGam=VkE=nXHQ8WB5judY3C3nNQBJCns-_f+A@mail.gmail.com> (Johan Herland's message of "Mon, 20 May 2013 15:48:15 +0200")
Johan Herland <johan@herland.net> writes:
>> Of course in either case we couldn't use a tree object directly, because
>> these new "reference tree" objects would refer not only to blobs and
>> other trees but also to commits and tags.
>
> Indeed. I don't know if the best solution would be to actually _allow_
> that (which would complicate the object parsing code somewhat; a tree
> entry pointing to a commit is usually interpreted as a submodule, but
> that is not what we'd want for the ref tree, and a tree entry pointing
> at a tag has AFAIK not yet been done), or whether it means we need to
> come up with a different kind of structure.
You can disallow that only by giving up on being able to express
Linus's kernel repository, which has an oddball v2.6.11-tree tag.
I do not think that that particular tag in the particular repository
is too big a show-stopper; if it is only Linus, we can ask him to
drop that tag (he has v2.6.11 tag object that points at the tree, so
the users do not lose anything) and be done with it.
But if there are other repositories that tag trees in a similar way,
that would be a real regression. We cannot just go ask people to
change their workflow that depended on using refs that directly
point at trees overnight.
next prev parent reply other threads:[~2013-05-20 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 13:48 Storing refs in the odb (was: Re: [PATCH 00/17] Remove assumptions about refname lifetimes) Johan Herland
2013-05-20 17:21 ` Junio C Hamano [this message]
2013-05-20 17:37 ` Storing refs in the odb Johan Herland
2013-05-20 18:28 ` Junio C Hamano
2013-05-20 18:44 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbo85wos9.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox