From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org, "Brandon Casey" <drafnel@gmail.com>,
"Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>,
"Brian Gernhardt" <brian@gernhardtsoftware.com>,
"Robin H. Johnson" <robbat2@gentoo.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] send-email: add extra safetly in address sanitazion
Date: Sun, 05 Feb 2012 13:52:21 -0800 [thread overview]
Message-ID: <7vbopdeyne.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <87sjipxe5u.fsf@thomas.inf.ethz.ch> (Thomas Rast's message of "Sun, 5 Feb 2012 20:39:57 +0100")
Thomas Rast <trast@inf.ethz.ch> writes:
> Am I the only one who stared at this for ten seconds, only to then
> realize that there is no sanitizing whatsoever going on here?
>
>> 'Foo Bar <foo@bar.com>>' -> 'Foo Bar <foo@bar.com>'
>> '"Foo Bar" <foo@bar.com>>' -> '"Foo Bar" <foo@bar.com>'
>> '<foo@bar.com>>' -> 'foo@bar.com'
>
> All of these are the same underlying issue. Does your patch fix any
> other malformed addresses, or just this particular type?
Just this particular type, as long as the code handles it correctly, would
be better than nothing.
On the recieving end in mailinfo, I think we also support
gitster@pobox.com (Junio C Hamano)
although it does not seem to be used by many people these days (the only
one I can remember seeing on this list was merlyn), so we may want to be a
bit more consistent between sending and receiving end, though.
next prev parent reply other threads:[~2012-02-05 21:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 16:32 [PATCH] send-email: add extra safetly in address sanitazion Felipe Contreras
2012-02-05 19:39 ` Thomas Rast
2012-02-05 20:51 ` Felipe Contreras
2012-02-05 21:51 ` Thomas Rast
2012-02-06 1:27 ` Felipe Contreras
2012-02-06 1:48 ` Junio C Hamano
2012-02-05 21:52 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-04 15:10 Felipe Contreras
2012-02-04 15:26 ` Felipe Contreras
2012-02-05 21:12 ` Junio C Hamano
2012-02-05 21:20 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbopdeyne.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=brian@gernhardtsoftware.com \
--cc=drafnel@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=robbat2@gentoo.org \
--cc=trast@inf.ethz.ch \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).