From: Junio C Hamano <gitster@pobox.com>
To: Gerrit Pape <pape@smarden.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] templates/hooks--*: don't refer to contrib hooks
Date: Mon, 26 Sep 2011 10:52:23 -0700 [thread overview]
Message-ID: <7vbou742eg.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110926125932.27854.qmail@804c778e7e6607.315fe32.mid.smarden.org> (Gerrit Pape's message of "Mon, 26 Sep 2011 12:59:32 +0000")
Gerrit Pape <pape@smarden.org> writes:
> Simplify the sample post-receive hook to not refer to some location of a
> contrib hook that might be installed in different locations on different
> systems. Instead simply provide a sample file that does nothing just as
> the post-commit sample hook.
>
> Signed-off-by: Gerrit Pape <pape@smarden.org>
> ---
> templates/hooks--post-receive.sample | 12 ++----------
> 1 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/templates/hooks--post-receive.sample b/templates/hooks--post-receive.sample
> index 7a83e17..5b1771f 100755
> --- a/templates/hooks--post-receive.sample
> +++ b/templates/hooks--post-receive.sample
> @@ -2,14 +2,6 @@
> #
> # An example hook script for the "post-receive" event.
> #
> +# To enable this hook, rename this file to "post-receive".
>
> +: Nothing
I removed the "-" lines above. Looking at the result, I really have to
wonder if it makes much sense to keep the file here. It is not even an
example anymore, and the user does not gain anything by enabling it,
following the suggestion.
Let's instead remove the file altogether, Ok?
next prev parent reply other threads:[~2011-09-26 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 12:59 [PATCH 2/2] templates/hooks--*: don't refer to contrib hooks Gerrit Pape
2011-09-26 17:52 ` Junio C Hamano [this message]
2011-09-27 11:56 ` [PATCH] templates/hooks--*: remove sample hooks without any functionality Gerrit Pape
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbou742eg.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).