From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Junio C Hamano <gitster@pobox.com>, Git ML <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] status: display "doing what" information in git status
Date: Thu, 05 May 2011 16:37:00 -0700 [thread overview]
Message-ID: <7vbozg67oj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1304632126-16733-1-git-send-email-madcoder@debian.org> (Pierre Habouzit's message of "Thu, 5 May 2011 23:48:46 +0200")
Pierre Habouzit <madcoder@debian.org> writes:
> @@ -732,6 +805,7 @@ void wt_status_print(struct wt_status *s)
> status_printf_ln(s, color(WT_STATUS_HEADER, s), "");
> }
>
> + wt_status_print_doingwhat(s);
> wt_status_print_updated(s);
> wt_status_print_unmerged(s);
> wt_status_print_changed(s);
I am very surprised that a new call to this function is added here.
As the "You are in middle of" information is useful mostly when you are on
detached head, I would have expected that the call would be inside the
if/elif chain near the top of wt_status_print() where we say "On branch"
vs "Not currently on...", to replace that information that comes from that
on_what variable.
next prev parent reply other threads:[~2011-05-05 23:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 21:48 [PATCH 1/1] status: display "doing what" information in git status Pierre Habouzit
2011-05-05 23:06 ` Sverre Rabbelier
2011-05-05 23:26 ` Pierre Habouzit
2011-05-06 7:48 ` Michael J Gruber
2011-05-06 8:04 ` Pierre Habouzit
2011-05-05 23:37 ` Junio C Hamano [this message]
2011-05-05 23:39 ` Pierre Habouzit
2011-05-05 23:47 ` Pierre Habouzit
2011-05-05 23:49 ` Junio C Hamano
2011-05-05 23:51 ` Pierre Habouzit
2011-05-06 7:38 ` [PATCH v2] " Pierre Habouzit
2011-05-06 10:13 ` Jakub Narebski
2011-05-06 17:40 ` Pierre Habouzit
2011-05-06 17:29 ` Junio C Hamano
2011-05-06 17:36 ` Pierre Habouzit
2011-05-06 18:24 ` Junio C Hamano
2011-05-06 18:40 ` Matthieu Moy
2011-05-06 18:44 ` Pierre Habouzit
2011-05-06 19:15 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbozg67oj.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).