git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: git@vger.kernel.org, Magnus Baeck <magnus.back@sonyericsson.com>,
	Avery Pennarun <apenwarr@gmail.com>,
	Jay Soffian <jaysoffian@gmail.com>,
	David Aguilar <davvid@gmail.com>
Subject: Re: git mergetool broken when rerere active
Date: Thu, 06 Jan 2011 10:56:29 -0800	[thread overview]
Message-ID: <7vbp3tc142.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.10.1101052119530.26654@debian> (Martin von Zweigbergk's message of "Wed\, 5 Jan 2011 22\:39\:07 -0500 \(EST\)")

Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:

> When rerere is enabled, git mergetool uses 'git rerere status' to find
> out which files to run the merge tool on. This was introduced in
> bb0a484 (mergetool: Skip autoresolved paths, 2010-08-17). Before that,
> 'git ls-files -u' was used, whether or not rerere was active.
>
> This change caused two problems:
>
>  (1) Before this change, it used to be that case that all conflicts
>      would be resolved and added to the index after running 'git
>      mergetool' without arguments, i.e. on all files. After the
>      change, conflicts of type 'deleted by them' or 'deleted by us'
>      would be ignored, since they are not listed shown by 'git rerere
>      status'.

Good point.  We used to say "everything that had conflict after a mergy
operation", now we say "everything that rerere attempted resolution but
didn't succeed".  Missing are paths that rerere didn't even attempt to
apply previous resolution at all.

Probably we would need a "git rerere remaining" sobcommand that is similar
to status but also includes the "punted" paths.

  parent reply	other threads:[~2011-01-06 18:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06  3:39 git mergetool broken when rerere active Martin von Zweigbergk
2011-01-06 12:47 ` Martin von Zweigbergk
2011-01-06 18:56 ` Junio C Hamano [this message]
2011-01-06 19:33   ` Junio C Hamano
2011-01-06 19:51     ` Martin von Zweigbergk
2011-01-07  2:50     ` Martin von Zweigbergk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbp3tc142.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=apenwarr@gmail.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jaysoffian@gmail.com \
    --cc=magnus.back@sonyericsson.com \
    --cc=martin.von.zweigbergk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).