git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Olson <mwolson@gnu.org>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>,
	Michael J Gruber <git@drmicha.warpmail.net>,
	Tim Stoakes <tim@stoakes.net>
Subject: Re: [PATCH/RFC 0/2] git-svn: Allow certain refs to be ignored
Date: Tue, 20 Apr 2010 16:58:35 -0700	[thread overview]
Message-ID: <7vbpddekwk.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <o2xc8b3bef91004201430m10bbe060q7d8ebd3a1ac4c3bd@mail.gmail.com> (Michael Olson's message of "Tue\, 20 Apr 2010 14\:30\:09 -0700")

Michael Olson <mwolson@gnu.org> writes:

> [svn-remote "svn"]
>        url = https://svn.my.org/svn/root
> ...
>        ignore-refs = ^refs/remotes/(tags/)?old/myorg

Traditionally configuration variable names are spelled camelCase without
dashes.  You probably would want to be consistent.

Also "refs" and any pathname-like things are traditionally matched using
globs and not regexes.  It is Ok to deviate if you have a strong reason to
(and I suspect it would make it easier to write "exclude" patterns like
the above example to allow a regex here), but that needs to be prominently
documented (e.g. "Unlike any other ref-matching configuration variable,
this alone uses regex, not glob") to avoid end user confusion.

  reply	other threads:[~2010-04-20 23:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 21:30 [PATCH/RFC 0/2] git-svn: Allow certain refs to be ignored Michael Olson
2010-04-20 23:58 ` Junio C Hamano [this message]
2010-04-21  7:15   ` Eric Wong
2010-04-21 16:31   ` Michael Olson
2010-04-21 16:54     ` Eric Wong
2010-04-21 17:02       ` Michael Olson
2010-04-21  7:18 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbpddekwk.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=mwolson@gnu.org \
    --cc=normalperson@yhbt.net \
    --cc=tim@stoakes.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).