* [PATCH] imap-send: suppress warning about cleartext password with CRAM-MD5
@ 2010-03-27 15:00 Chris Webb
2010-03-28 16:25 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Chris Webb @ 2010-03-27 15:00 UTC (permalink / raw)
To: git
If a CRAM-MD5 challenge-response is used to authenticate to the IMAP server,
git imap-send shouldn't warn about the password being sent in the clear.
Signed-off-by: Chris Webb <chris@arachsys.com>
---
imap-send.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index aeb2985..7107923 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1226,9 +1226,6 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
fprintf(stderr, "Skipping account %s@%s, server forbids LOGIN\n", srvc->user, srvc->host);
goto bail;
}
- if (!imap->buf.sock.ssl)
- imap_warn("*** IMAP Warning *** Password is being "
- "sent in the clear\n");
if (srvc->auth_method) {
struct imap_cmd_cb cb;
@@ -1253,6 +1250,9 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
goto bail;
}
} else {
+ if (!imap->buf.sock.ssl)
+ imap_warn("*** IMAP Warning *** Password is being "
+ "sent in the clear\n");
if (imap_exec(ctx, NULL, "LOGIN \"%s\" \"%s\"", srvc->user, srvc->pass) != RESP_OK) {
fprintf(stderr, "IMAP error: LOGIN failed\n");
goto bail;
--
1.7.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] imap-send: suppress warning about cleartext password with CRAM-MD5
2010-03-27 15:00 [PATCH] imap-send: suppress warning about cleartext password with CRAM-MD5 Chris Webb
@ 2010-03-28 16:25 ` Junio C Hamano
2010-03-30 10:51 ` Hitoshi Mitake
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2010-03-28 16:25 UTC (permalink / raw)
To: Chris Webb; +Cc: git, Hitoshi Mitake
Chris Webb <chris@arachsys.com> writes:
> If a CRAM-MD5 challenge-response is used to authenticate to the IMAP server,
> git imap-send shouldn't warn about the password being sent in the clear.
>
> Signed-off-by: Chris Webb <chris@arachsys.com>
> ---
Makes sense. Thanks.
> imap-send.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index aeb2985..7107923 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1226,9 +1226,6 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
> fprintf(stderr, "Skipping account %s@%s, server forbids LOGIN\n", srvc->user, srvc->host);
> goto bail;
> }
> - if (!imap->buf.sock.ssl)
> - imap_warn("*** IMAP Warning *** Password is being "
> - "sent in the clear\n");
>
> if (srvc->auth_method) {
> struct imap_cmd_cb cb;
> @@ -1253,6 +1250,9 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
> goto bail;
> }
> } else {
> + if (!imap->buf.sock.ssl)
> + imap_warn("*** IMAP Warning *** Password is being "
> + "sent in the clear\n");
> if (imap_exec(ctx, NULL, "LOGIN \"%s\" \"%s\"", srvc->user, srvc->pass) != RESP_OK) {
> fprintf(stderr, "IMAP error: LOGIN failed\n");
> goto bail;
> --
> 1.7.0.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] imap-send: suppress warning about cleartext password with CRAM-MD5
2010-03-28 16:25 ` Junio C Hamano
@ 2010-03-30 10:51 ` Hitoshi Mitake
0 siblings, 0 replies; 3+ messages in thread
From: Hitoshi Mitake @ 2010-03-30 10:51 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Chris Webb, git
On 03/29/10 01:25, Junio C Hamano wrote:
> Chris Webb<chris@arachsys.com> writes:
>
>> If a CRAM-MD5 challenge-response is used to authenticate to the IMAP
server,
>> git imap-send shouldn't warn about the password being sent in the clear.
>>
>> Signed-off-by: Chris Webb<chris@arachsys.com>
>> ---
>
> Makes sense. Thanks.
>
>> imap-send.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/imap-send.c b/imap-send.c
>> index aeb2985..7107923 100644
>> --- a/imap-send.c
>> +++ b/imap-send.c
>> @@ -1226,9 +1226,6 @@ static struct store *imap_open_store(struct
imap_server_conf *srvc)
>> fprintf(stderr, "Skipping account %s@%s, server forbids
LOGIN\n", srvc->user, srvc->host);
>> goto bail;
>> }
>> - if (!imap->buf.sock.ssl)
>> - imap_warn("*** IMAP Warning *** Password is being "
>> - "sent in the clear\n");
>>
>> if (srvc->auth_method) {
>> struct imap_cmd_cb cb;
>> @@ -1253,6 +1250,9 @@ static struct store *imap_open_store(struct
imap_server_conf *srvc)
>> goto bail;
>> }
>> } else {
>> + if (!imap->buf.sock.ssl)
>> + imap_warn("*** IMAP Warning *** Password is being "
>> + "sent in the clear\n");
>> if (imap_exec(ctx, NULL, "LOGIN \"%s\" \"%s\"", srvc->user,
srvc->pass) != RESP_OK) {
>> fprintf(stderr, "IMAP error: LOGIN failed\n");
>> goto bail;
>> --
>> 1.7.0.1
>
Thanks Chris, this was my mistake.
And thanks for your notify, Junio.
Hitoshi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-30 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-27 15:00 [PATCH] imap-send: suppress warning about cleartext password with CRAM-MD5 Chris Webb
2010-03-28 16:25 ` Junio C Hamano
2010-03-30 10:51 ` Hitoshi Mitake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).