git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	git <git@vger.kernel.org>,
	mike.lifeguard@gmail.com
Subject: Re: Tree with leading '0' modes in 1.7.0.3
Date: Fri, 26 Mar 2010 16:09:02 -0700	[thread overview]
Message-ID: <7vbpeaadf5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100326224038.GA18454@progeny.tock> (Jonathan Nieder's message of "Fri\, 26 Mar 2010 17\:40\:39 -0500")

Jonathan Nieder <jrnieder@gmail.com> writes:

> Shawn O. Pearce wrote:
>> Jonathan Nieder <jrnieder@gmail.com> wrote:
>>> Shawn O. Pearce wrote:
>
>>>> Any ideas?  Why is Git 1.7.0.3 jamming a leading '0' on a file mode?
>>> 
>>> See http://thread.gmane.org/gmane.comp.version-control.git/141028
>>> and commit c88f0cc (notes: fix malformed tree entry, 2010-02-24).
>>> 
>>> The regression that that fixes appeared in 61a7cca0 (Notes API:
>>> write_notes_tree(): Store the notes tree in the database, 2010-02-13),
>>> which is not part of 1.7.0.3.
>>
>> That may be true... but I doubt the tree in question was a notes
>> tree.  The path entries were names like 'README', 'modules' and
>> 'stewardbot'.  Something I would assume was the project's source
>> tree, not its notes tree.
>
> Yes, true.  The problem is probably elsewhere, especially because
> 1.7.0.3 doesn’t even have that commit.  Still, I find this a bit
> strange because such breakage should have been noticeable if it
> happens often.
>
> What has changed recently that involves writing trees?

Asking grep for "%06o" reveals nothing.  Perhaps somebody else's imitation
implementation?

  reply	other threads:[~2010-03-26 23:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26 21:56 Tree with leading '0' modes in 1.7.0.3 Shawn O. Pearce
2010-03-26 22:26 ` Jonathan Nieder
2010-03-26 22:29   ` Shawn O. Pearce
2010-03-26 22:40     ` Jonathan Nieder
2010-03-26 23:09       ` Junio C Hamano [this message]
2010-03-26 22:59     ` Mike.lifeguard
2010-03-26 23:05       ` Shawn O. Pearce
2010-03-26 23:22         ` Mike.lifeguard
2010-03-26 23:49           ` Jonathan Nieder
2010-03-26 23:50         ` Junio C Hamano
2010-03-26 23:56           ` Avery Pennarun
2010-03-27  0:00             ` Mike.lifeguard
2010-03-27  1:22               ` Shawn O. Pearce
2010-03-27  1:30                 ` Nicolas Pitre
2010-03-27  1:34                   ` Shawn O. Pearce
2010-03-27  1:56                     ` Nicolas Pitre
2010-03-27  2:33                       ` Avery Pennarun
2010-03-27 12:44                       ` Scott Chacon
2010-03-27 14:21                         ` Nicolas Pitre
2010-03-27 19:14                           ` Shawn O. Pearce
2010-03-27 19:30                             ` A Large Angry SCM
2010-03-27 19:32                               ` Shawn O. Pearce
2010-03-27 19:39                                 ` A Large Angry SCM
2010-03-27 19:44                                   ` A Large Angry SCM
2010-03-27 19:57                                     ` A Large Angry SCM
2010-03-28 17:38                                     ` Sitaram Chamarty
2010-03-28 23:28                                       ` A Large Angry SCM
2010-03-27 20:13                             ` A Large Angry SCM
2010-03-27 20:16                             ` Junio C Hamano
2010-03-27 22:16                             ` Avery Pennarun
2010-03-27  5:16                     ` Junio C Hamano
2010-03-27 19:20                       ` Shawn O. Pearce
2010-03-27 20:04                         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbpeaadf5.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=mike.lifeguard@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).