Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Greg Bacon <gbacon@dbresearch.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] No diff -b/-w output for all-whitespace changes
Date: Thu, 19 Nov 2009 14:06:19 -0800	[thread overview]
Message-ID: <7vbpiy9nl0.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1258665144-26520-1-git-send-email-gbacon@dbresearch.net> (Greg Bacon's message of "Thu\, 19 Nov 2009 15\:12\:24 -0600")

Greg Bacon <gbacon@dbresearch.net> writes:

> Change git-diff's whitespace-ignoring modes to generate
> output only if a non-empty patch results, which git-apply
> rejects.
>
> Update the tests to look for the new behavior.
>
> Signed-off-by: Greg Bacon <gbacon@dbresearch.net>

Thanks.

I didn't read the patch carefully, but I think this is the right thing to
do and is in the same sprit as jc/1.7.0-diff-whitespace-only-status topic.

  reply	other threads:[~2009-11-19 22:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 21:12 [PATCH] No diff -b/-w output for all-whitespace changes Greg Bacon
2009-11-19 22:06 ` Junio C Hamano [this message]
2009-11-19 22:14 ` Thomas Rast
2009-11-19 22:25   ` Greg Bacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbpiy9nl0.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=gbacon@dbresearch.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox