From: Junio C Hamano <gitster@pobox.com>
To: Jari Aalto <jari.aalto@cante.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Documentation/git-add.txt: Explain --patch option in layman terms
Date: Sun, 30 Aug 2009 16:20:23 -0700 [thread overview]
Message-ID: <7vbplw28js.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <87ab1gaol2.fsf@jondo.cante.net> (Jari Aalto's message of "Mon\, 31 Aug 2009 02\:06\:49 +0300")
Jari Aalto <jari.aalto@cante.net> writes:
> Your proposal that starts:
>
> ...but bypass the initial command menu
No, it doesn't..
Go re-read the message you are responding to, paying extra attention to
the parts you snipped from your quote, which was the important part you
should have read before you responded.
If you want to start the description with "What it does/what it is used
for", I think it is a good idea. I already made a suggestion for such an
improvement in my message you are responding to.
Now, what was that suggestion?
It is in the message your first response was a follow-up to. Again you
didn't quote the relevant part in that response, and perhaps that was
because you did not even read it before responding.
If you assume that the reader is not familiar with "add -i", then the
above is not descriptive enough, but "Run interactive patch command" is
not an improvement either. We would need a description of "what it is
used for" before "how it would look to you" (i.e.. my rewrite shown
above).
"What it is used for" would perhaps read like this.
Review the difference between the index and the work tree, and add
modified contents to the index interactively by choosing which
patch hunks to use.
This time I re-quoted things for you because your responses obviously were
written without reading or understanding them, but please be careful not
to make me do this. I do not have infinite time.
next prev parent reply other threads:[~2009-08-30 23:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 17:29 [PATCH] Documentation/git-add.txt: Explain --patch option in layman terms Jari Aalto
2009-08-30 20:14 ` Junio C Hamano
2009-08-30 21:02 ` Jeff King
2009-08-30 21:56 ` Jari Aalto
2009-08-30 22:13 ` Junio C Hamano
2009-08-30 23:06 ` Jari Aalto
2009-08-30 23:20 ` Junio C Hamano [this message]
2009-08-31 7:46 ` Jari Aalto
2009-08-31 23:42 ` Junio C Hamano
2009-09-13 6:44 ` [PATCH] Improve --patch option documentation in git-add Jari Aalto
2009-09-13 13:48 ` Mikael Magnusson
2009-09-13 14:09 ` Jari Aalto
2009-09-14 13:13 ` Sean Estabrooks
2009-09-15 5:35 ` [PATCH] Improve --patch option documentation in git-add (updated patch) Jari Aalto
2009-09-15 6:52 ` Nanako Shiraishi
2009-09-15 8:17 ` Jari Aalto
2009-09-15 10:35 ` Nanako Shiraishi
2009-08-30 23:31 ` [PATCH] Documentation/git-add.txt: Explain --patch option in layman terms Junio C Hamano
2009-08-31 7:06 ` Jari Aalto
2009-08-31 7:32 ` Junio C Hamano
2009-08-30 22:00 ` Jari Aalto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbplw28js.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).