Re: [PATCH] Allow curl to rewind the read buffers

[Junio C Hamano <gitster@pobox.com>]

Martin Storsjö <martin@martin.st> writes:

> Rewinding of the read buffers may be needed when doing HTTP PUT or POST
> (or PROPFIND) with multi-pass authentication methods.

It may be obvious to people proficient in cURL, but I had to guess that
you perhaps meant to say "when using multi-pass authentication methods,
cURL library may need to rewind the read buffers (depending on what is fed
by the server), and in order to allow the library to do so, we need to
tell it how by providing the way to manipulate the buffers we supply with
these IOCTL callbacks."

Do I understand you correctly?

My point is that the your two-line statement of fact (with a bit more
explanation of the fact that follows) was clear but it was unclear to me
how that fact translates to the need of what the patch does.  We would
want the commit log message to be helpful to people who look at the code 6
months down the line and wonder why these lines were added.

Please do not make me guess.  I won't claim that other people would be
even less clueful than I am, but I am reasonably sure that more than half
of the people who read this patch would share my uneasiness of not clearly
reading how your statement of fact leads to your conclusion.

Thanks.