From: Junio C Hamano <gitster@pobox.com>
To: malc@pulsesoft.com, Vassili Karpov <av1474@comtv.ru>
Cc: git@vger.kernel.org, Alexandre Julliard <julliard@winehq.org>
Subject: Re: [PATCH] Change octal literals to be XEmacs friendly
Date: Fri, 23 Jan 2009 00:09:04 -0800 [thread overview]
Message-ID: <7vbpty1m1r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <871vuwbnio.fsf@linmac.oyster.ru> (malc@pulsesoft.com's message of "Wed, 21 Jan 2009 20:02:39 +0300")
malc@pulsesoft.com writes:
> case uses eql and (eql ?\001 1) evaluates to nil under XEmacs
> (probably because some internal type of ?\001 is char)
And I presume the new way to spell is compatible with non XEmacs emacs?
It may be obvious to you, but please spell it out. Parenthesized
"probably" does not help building the confidence in the patch either.
> Signed-off-by: Vassili Karpov <av1474@comtv.ru>
How are the (nameless) author of the patch malc@pulsesoft.com and Vassili
Karpov, the person who signed off, related?
Next time, please spend a few minutes to see if there are active
developers who are familiar in the area you are touching, and Cc your
patch to ask their input.
git blame -L562,+29 contrib/emacs/git.el
tells me that most of this came from 40f162b (git.el: Display file types
and type changes., 2008-01-06) by Alexandre, so I am Cc'ing him.
> ---
> contrib/emacs/git.el | 30 +++++++++++++++---------------
> 1 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
> index 09e8bae..715580a 100644
> --- a/contrib/emacs/git.el
> +++ b/contrib/emacs/git.el
> @@ -562,29 +562,29 @@ the process output as a string, or nil if the git command failed."
> (let* ((old-type (lsh (or old-perm 0) -9))
> (new-type (lsh (or new-perm 0) -9))
> (str (case new-type
> - (?\100 ;; file
> + (#o100 ;; file
> (case old-type
> - (?\100 nil)
> - (?\120 " (type change symlink -> file)")
> - (?\160 " (type change subproject -> file)")))
> - (?\120 ;; symlink
> + (#o100 nil)
> + (#o120 " (type change symlink -> file)")
> + (#o160 " (type change subproject -> file)")))
> + (#o120 ;; symlink
> (case old-type
> - (?\100 " (type change file -> symlink)")
> - (?\160 " (type change subproject -> symlink)")
> + (#o100 " (type change file -> symlink)")
> + (#o160 " (type change subproject -> symlink)")
> (t " (symlink)")))
> - (?\160 ;; subproject
> + (#o160 ;; subproject
> (case old-type
> - (?\100 " (type change file -> subproject)")
> - (?\120 " (type change symlink -> subproject)")
> + (#o100 " (type change file -> subproject)")
> + (#o120 " (type change symlink -> subproject)")
> (t " (subproject)")))
> - (?\110 nil) ;; directory (internal, not a real git state)
> - (?\000 ;; deleted or unknown
> + (#o110 nil) ;; directory (internal, not a real git state)
> + (#o000 ;; deleted or unknown
> (case old-type
> - (?\120 " (symlink)")
> - (?\160 " (subproject)")))
> + (#o120 " (symlink)")
> + (#o160 " (subproject)")))
> (t (format " (unknown type %o)" new-type)))))
> (cond (str (propertize str 'face 'git-status-face))
> - ((eq new-type ?\110) "/")
> + ((eq new-type #o110) "/")
> (t ""))))
>
> (defun git-rename-as-string (info)
>
> --
> mailto:av1474@comtv.ru
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-23 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 17:02 [PATCH] Change octal literals to be XEmacs friendly malc
2009-01-23 8:09 ` Junio C Hamano [this message]
2009-01-23 19:53 ` malc
2009-01-23 20:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbpty1m1r.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=av1474@comtv.ru \
--cc=git@vger.kernel.org \
--cc=julliard@winehq.org \
--cc=malc@pulsesoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).