git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Henrik Austad <henrik@austad.us>
Cc: git@vger.kernel.org, Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: git checkout does not warn about tags without corresponding commits
Date: Sat, 03 Jan 2009 03:53:28 -0800	[thread overview]
Message-ID: <7vbpuo7ghz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vr63k8vvf.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sat, 03 Jan 2009 03:36:04 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> I haven't looked at the code very closely, but I think this should fix
> it.  Thorough reviewing (not just running the test suite) is much
> appreciated.

Just for fun, this will apply to 782c2d6 (Build in checkout, 2008-02-07)
and seems to fix the issue ;-)

No, I am not going to issue a maintenance release for 1.5.5 just to
include this fix, even though I could.  I do not think this is a grave
enough regression to warrant a backport beyond 1.6.0 series.

 builtin-checkout.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git i/builtin-checkout.c w/builtin-checkout.c
index 59a0ef4..1d0de68 100644
--- i/builtin-checkout.c
+++ w/builtin-checkout.c
@@ -435,6 +435,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
 			argv++;
 			argc--;
 		} else if ((source_tree = parse_tree_indirect(rev))) {
+			new.name = arg;
 			argv++;
 			argc--;
 		}

  reply	other threads:[~2009-01-03 11:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-02 12:25 git checkout does not warn about tags without corresponding commits Henrik Austad
2009-01-02 15:04 ` Miklos Vajna
2009-01-02 21:44 ` Junio C Hamano
2009-01-03 11:00   ` Henrik Austad
2009-01-03 11:36     ` Junio C Hamano
2009-01-03 11:53       ` Junio C Hamano [this message]
2009-01-03 12:37       ` Henrik Austad
2009-01-03 19:31       ` Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbpuo7ghz.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=henrik@austad.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).