git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Scott Chacon <schacon@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] added a built-in alias for 'stage' to the 'add' command
Date: Mon, 01 Dec 2008 17:38:20 -0800	[thread overview]
Message-ID: <7vbpvvqrub.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081201172902.GA41963@agadorsparticus> (Scott Chacon's message of "Mon, 1 Dec 2008 09:29:02 -0800")

Scott Chacon <schacon@gmail.com> writes:

> Subject: Re: [PATCH] added a built-in alias for 'stage' to the 'add' command

s/added/Add/;

Write your commit log message in present tense (recall David Brown's talk
at GitTogether '08? ;-)

> this comes from conversation at the GitTogether where we thought it would

s/this/This/;

> be helpful to be able to teach people to 'stage' files because it tends
> to cause confusion when told that they have to keep 'add'ing them.
>
> This continues the movement to start referring to the index as a
> staging area (eg: the --staged alias to 'git diff'). Also added a
> doc file for 'git stage' that basically points to the docs for
> 'git add'.
>
> Signed-off-by: Scott Chacon <schacon@gmail.com>

I think this is fine but I'd rather not risk the documentation getting
stale over time, so...

> +SYNOPSIS
> +--------
> +[verse]
> +'git stage' [-n] [-v] [--force | -f] [--interactive | -i] [--patch | -p]
> +	  [--all | [--update | -u]] [--intent-to-add | -N]
> +	  [--refresh] [--ignore-errors] [--] <filepattern>...

...I think this should read something like

	'git stage' args...

      parent reply	other threads:[~2008-12-02  1:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 17:29 [PATCH] added a built-in alias for 'stage' to the 'add' command Scott Chacon
2008-12-01 18:25 ` Jeff King
2008-12-02  1:38 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbpvvqrub.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=schacon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).